Skip to content

Commit eb5c0c8

Browse files
committed
remove PR gating
1 parent 9997d21 commit eb5c0c8

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/build-test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -729,6 +729,8 @@ jobs:
729729

730730
# We don't expect to keep being clippy-clean on nightly Rust,
731731
# so the "toolchain boilerplate" is deliberately omitted
732+
# This just means we end up testing on the pinned stable even in the cronjob
733+
# CI, which isn't that useful but specially omitting that task is more work than it's worth
732734

733735
# Clippy job > Install and run clippy steps
734736
- name: Install clippy

Makefile.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ if not ${event_name}
194194
end
195195
196196
is_schedule = eq "${event_name}" "schedule"
197-
is_pr = eq "${event_name}" "pull_request"
198197
is_dispatch = eq "${event_name}" "workflow_dispatch"
199198
dispatch_needs_nightly = set false
200199
@@ -207,7 +206,7 @@ if is_dispatch
207206
end
208207
end
209208
210-
if ${is_schedule} or ${is_pr} or ${dispatch_needs_nightly}
209+
if ${is_schedule} or ${dispatch_needs_nightly}
211210
echo "Setting up CI environment for forced-nightly Rust build"
212211
appendfile ${env_file} "ICU4X_NIGHTLY_TOOLCHAIN=nightly\n"
213212
appendfile ${env_file} "INSTALLED_NIGHTLY_VERSION=nightly\n"

0 commit comments

Comments
 (0)