fix: BSPlineKit 0.18 is not breaking, but now exports fit, which runs into a conflict (#252)

* fix: BSPlineKit 0.18 is not breaking, but now exports fit, which runs into a conflict

* fix BSplinekit - import rather tha using

* BSplineKit: basis_to_array_index imported

Author: behinger

docs/literate/explanations/nonlinear_effects.jl

@@ -2,7 +2,8 @@
 
 
 
-using BSplineKit, Unfold
+import BSplineKit
+using Unfold
 using CairoMakie
 using DataFrames
 using Random

docs/src/references/extensions.md

@@ -17,7 +17,7 @@ using Unfold
 To use robust (outlier-"safe") solvers support as described in @Ref(custom_solvers) you have to:
 
 ```julia
-using RobustSolvers
+import RobustSolvers
 using Unfold
 ```
 
@@ -26,7 +26,7 @@ using Unfold
 Finally to use non-linear effects/splines like in `@formula 0~1+spl(continuous,5)` you have to use:
 
 ```julia
-using BSplineKit
+import BSplineKit
 using Unfold
 ```
 

ext/UnfoldBSplineKitExt/UnfoldBSplineKitExt.jl

@@ -1,6 +1,12 @@
 module UnfoldBSplineKitExt
 using Unfold
-using BSplineKit
+import BSplineKit:
+    BSplineOrder,
+    BSplineBasis,
+    boundaries,
+    period,
+    PeriodicBSplineBasis,
+    basis_to_array_index
 using StatsModels
 import StatsModels: termvars, width, coefnames, modelcols, apply_schema
 import Base: show

ext/UnfoldBSplineKitExt/basisfunctions.jl

@@ -25,7 +25,7 @@ end
 
 function splinekernel(e, times, nsplines)
     breakpoints = spl_breakpoints(times, nsplines)
-    basis = BSplineKit.BSplineBasis(BSplineOrder(4), breakpoints)  # 4= cubic
+    basis = BSplineBasis(BSplineOrder(4), breakpoints)  # 4= cubic
     return sparse(splFunction(times, basis))
 end
 

ext/UnfoldBSplineKitExt/splinepredictors.jl

@@ -100,7 +100,7 @@ function splFunction(x::AbstractVector, spl::PeriodicBSplineTerm)
 end
 
 function splFunction(x::AbstractVector, spl::BSplineTerm)
-    basis = BSplineKit.BSplineBasis(BSplineOrder(spl.order), deepcopy(spl.breakpoints))
+    basis = BSplineBasis(BSplineOrder(spl.order), deepcopy(spl.breakpoints))
     _splFunction(x, basis)
 end
 #spl(x,df) = Splines2.bs(x,df=df,intercept=true) # assumes intercept

test/setup.jl

@@ -10,7 +10,7 @@ using StatsBase
 using Missings
 using StableRNGs
 
-using RobustModels, BSplineKit # extensionTriggers
+import RobustModels, BSplineKit # extensionTriggers
 using SparseArrays
 using UnfoldSim
 using Interpolations