Skip to content

Commit b7aa8c2

Browse files
committed
#127: don't use an ID for hidden input
1 parent b8edc05 commit b7aa8c2

File tree

7 files changed

+15
-6
lines changed

7 files changed

+15
-6
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Yii2 multiple input change log
22
==============================
33

4+
2.5.0
5+
=====
6+
7+
- #127: fixed js actions
8+
49
2.4.0
510
=====
611

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Yii2 widget for handle multiple inputs for an attribute of model and tabular inp
88
[![License](https://poser.pugx.org/unclead/yii2-multiple-input/license)](https://packagist.org/packages/unclead/yii2-multiple-input)
99

1010
##Latest release
11-
The latest stable version of the extension is v2.4.0 Follow the [instruction](./UPGRADE.md) for upgrading from previous versions
11+
The latest stable version of the extension is v2.5.0 Follow the [instruction](./UPGRADE.md) for upgrading from previous versions
1212

1313
##Installation
1414
The preferred way to install this extension is through [composer](http://getcomposer.org/download/).

UPGRADE.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ if you want to upgrade from version A to version C and there is
88
version B between A and C, you need to following the instructions
99
for both A and B.
1010

11+
Upgrade from 2.2.0 tp 2.3.0
12+
---------------------------
13+
14+
- Ensure that you set `id` option in case you are using js actions, otherwise you old code won't work.
15+
1116
Upgrade from 2.0.0 tp 2.0.1
1217
---------------------------
1318

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"yii2 tabular input"
1010
],
1111
"type": "yii2-extension",
12-
"version": "2.4.0",
12+
"version": "2.5.0",
1313
"license": "BSD-3-Clause",
1414
"support": {
1515
"issues": "https://github.com/unclead/yii2-multiple-input/issues?state=open",

examples/views/multiple-input.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
<h3>Multiple columns</h3>
4848
<?php
4949
echo $form->field($model, 'schedule')->widget(MultipleInput::className(), [
50+
'id' => 'examplemodel-schedule',
5051
'max' => 4,
5152
'allowEmptyList' => true,
5253
'rowOptions' => function($model) {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jquery.multipleInput",
3-
"version": "2.4.0",
3+
"version": "2.5.0",
44
"description": "jQuery multipleInput",
55
"scripts": {
66
"build": "npm install && (gulp || node node_modules/gulp/bin/gulp.js)"

src/MultipleInput.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,7 @@ public function run()
195195
{
196196
$content = '';
197197
if ($this->hasModel() && $this->isEmbedded === false) {
198-
$content .= Html::hiddenInput(Html::getInputName($this->model, $this->attribute), null, [
199-
'id' => Html::getInputId($this->model, $this->attribute)
200-
]);
198+
$content .= Html::hiddenInput(Html::getInputName($this->model, $this->attribute), null);
201199
}
202200
$content .= $this->createRenderer()->render();
203201

0 commit comments

Comments
 (0)