move collecting js expressions to a separate class

Author: Eugene Tupikov

src/components/JsCollector.php

@@ -0,0 +1,113 @@
+<?php
+
+namespace unclead\multipleinput\components;
+
+use yii\helpers\ArrayHelper;
+use yii\web\View;
+
+class JsCollector
+{
+    const POSITIONS_ORDER = [View::POS_HEAD, View::POS_BEGIN, View::POS_END, View::POS_READY, View::POS_LOAD];
+
+    /**
+     * @var View
+     */
+    private $view;
+
+    /**
+     * @var array
+     */
+    private $jsExclude = [];
+
+    /**
+     * @var array
+     */
+    private $jsInit = [];
+
+    /**
+     * @var array
+     */
+    private $jsTemplates = [];
+
+    public function __construct($view)
+    {
+        $this->view = $view;
+    }
+
+    public function onBeforeRender()
+    {
+        if (!is_array($this->view->js)) {
+            return;
+        }
+
+        $this->jsExclude = [];
+        foreach ($this->view->js as $position => $scripts) {
+            foreach ((array)$scripts as $key => $js) {
+                if (!isset($this->jsExclude[$position])) {
+                    $this->jsExclude[$position] = [];
+                }
+
+                $this->jsExclude[$position][$key] = $js;
+            }
+        }
+    }
+
+    public function onAfterRender()
+    {
+        if (!is_array($this->view->js)) {
+            return;
+        }
+
+        foreach (self::POSITIONS_ORDER as $position) {
+            foreach (ArrayHelper::getValue($this->view->js, $position, []) as $key => $js) {
+                if (isset($this->jsExclude[$position][$key])) {
+                    continue;
+                }
+
+                $this->jsExclude[$position][$key] = $js;
+
+                $this->jsInit[$key] = $js;
+
+                unset($this->view->js[$position][$key]);
+            }
+        }
+    }
+
+    public function onAfterPrepareTemplate()
+    {
+        if (!is_array($this->view->js)) {
+            return;
+        }
+
+        $this->jsTemplates = [];
+
+        foreach (self::POSITIONS_ORDER as $position) {
+            foreach (ArrayHelper::getValue($this->view->js, $position, []) as $key => $js) {
+                if (isset($this->jsExclude[$position][$key])) {
+                    continue;
+                }
+
+                $this->jsTemplates[$key] = $js;
+
+                unset($this->view->js[$position][$key]);
+            }
+        }
+
+    }
+
+    /**
+     * @return array
+     */
+    public function getJsInit()
+    {
+        return $this->jsInit;
+    }
+
+    /**
+     * @return array
+     */
+    public function getJsTemplates()
+    {
+        return $this->jsTemplates;
+    }
+}

src/renderers/BaseRenderer.php

@@ -24,6 +24,7 @@
 use unclead\multipleinput\TabularInput;
 use unclead\multipleinput\assets\MultipleInputAsset;
 use unclead\multipleinput\assets\MultipleInputSortableAsset;
+use unclead\multipleinput\components\JsCollector;
 use unclead\multipleinput\components\BaseColumn;
 
 /**
@@ -355,64 +356,35 @@ protected function getExtraButtons($index, $item)
         return $content;
     }
 
+    /**
+     * @return mixed
+     *
+     * @throws InvalidConfigException
+     * @throws NotSupportedException
+     */
     public function render()
     {
         $this->initColumns();
 
         $view = $this->context->getView();
         MultipleInputAsset::register($view);
 
-        // Collect all js scripts which were added before rendering of our widget
-        $jsBefore= [];
-        if (is_array($view->js)) {
-            foreach ($view->js as $position => $scripts) {
-                foreach ((array)$scripts as $key => $js) {
-                    if (!isset($jsBefore[$position])) {
-                        $jsBefore[$position] = [];
-                    }
-                    $jsBefore[$position][$key] = $js;
-                }
-            }
-        }
+        $jsCollector = new JsCollector($view);
 
-        $content  = $this->internalRender();
+        $jsCollector->onBeforeRender();
 
-        // Collect all js scripts which has to be appended to page before initialization widget
-        $jsInit = [];
-        if (is_array($view->js)) {
-            foreach ($this->jsPositions as $position) {
-                foreach (ArrayHelper::getValue($view->js, $position, []) as $key => $js) {
-                    if (isset($jsBefore[$position][$key])) {
-                        continue;
-                    }
-                    $jsInit[$key] = $js;
-                    $jsBefore[$position][$key] = $js;
-                    unset($view->js[$position][$key]);
-                }
-            }
-        }
+        $content = $this->internalRender();
+        $jsCollector->onAfterRender();
 
         $template = $this->prepareTemplate();
-
-        $jsTemplates = [];
-        if (is_array($view->js)) {
-            foreach ($this->jsPositions as $position) {
-                foreach (ArrayHelper::getValue($view->js, $position, []) as $key => $js) {
-                    if (isset($jsBefore[$position][$key])) {
-                        continue;
-                    }
-                    $jsTemplates[$key] = $js;
-                    unset($view->js[$position][$key]);
-                }
-            }
-        }
+        $jsCollector->onAfterPrepareTemplate();
 
         $options = Json::encode(array_merge([
             'id'                => $this->id,
             'inputId'           => $this->context->options['id'],
             'template'          => $template,
-            'jsInit'            => $jsInit,
-            'jsTemplates'       => $jsTemplates,
+            'jsInit'            => $jsCollector->getJsInit(),
+            'jsTemplates'       => $jsCollector->getJsTemplates(),
             'max'               => $this->max,
             'min'               => $this->min,
             'attributes'        => $this->prepareJsAttributes(),
@@ -444,7 +416,7 @@ private function registerJsSortable()
     /**
      * Returns an array of JQuery sortable plugin options.
      * You can override this method extend plugin behaviour.
-     * 
+     *
      * @return array
      */
     protected function getJsSortableOptions()