From 5a078d53141392a6dfd5b119ec46c8dc50857c26 Mon Sep 17 00:00:00 2001 From: Sebastian Landwehr Date: Thu, 5 Jun 2025 16:42:10 +0000 Subject: [PATCH 1/4] fix: do not consider resolved path in extensions rule --- src/rules/extensions.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/rules/extensions.ts b/src/rules/extensions.ts index 73bb6a75..713be5c4 100644 --- a/src/rules/extensions.ts +++ b/src/rules/extensions.ts @@ -326,11 +326,7 @@ export default createRule({ return } - const resolvedPath = resolve(importPath, context) - - // get extension from resolved path, if possible. - // for unresolved, use source value. - const extension = path.extname(resolvedPath || importPath).slice(1) + const extension = path.extname(importPath).slice(1) // determine if this is a module const isPackage = From b591be979b49ffb5ab32dfa72b51e1ec9e541510 Mon Sep 17 00:00:00 2001 From: Sebastian Landwehr Date: Thu, 5 Jun 2025 17:01:01 +0000 Subject: [PATCH 2/4] take extension from import path or resolved path --- src/rules/extensions.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/rules/extensions.ts b/src/rules/extensions.ts index 713be5c4..ceb31df5 100644 --- a/src/rules/extensions.ts +++ b/src/rules/extensions.ts @@ -326,7 +326,9 @@ export default createRule({ return } - const extension = path.extname(importPath).slice(1) + const resolvedPath = resolve(importPath, context) + + const extension = path.extname(importPath)?.slice?.(1) || path.extname(resolvedPath).slice(1) // determine if this is a module const isPackage = From bed3350c096eefce56df9e1127e0919fba81c0f6 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Thu, 5 Jun 2025 17:01:51 +0000 Subject: [PATCH 3/4] [autofix.ci] apply automated fixes --- src/rules/extensions.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/rules/extensions.ts b/src/rules/extensions.ts index ceb31df5..319cb55c 100644 --- a/src/rules/extensions.ts +++ b/src/rules/extensions.ts @@ -327,8 +327,10 @@ export default createRule({ } const resolvedPath = resolve(importPath, context) - - const extension = path.extname(importPath)?.slice?.(1) || path.extname(resolvedPath).slice(1) + + const extension = + path.extname(importPath)?.slice?.(1) || + path.extname(resolvedPath).slice(1) // determine if this is a module const isPackage = From e6f8e88ace66120720f8a3ab509503162d72c9f6 Mon Sep 17 00:00:00 2001 From: Sebastian Landwehr Date: Thu, 5 Jun 2025 18:18:00 +0000 Subject: [PATCH 4/4] fix: restore previous behavior but only use resolved path if import path doesn't have an extension --- src/rules/extensions.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/rules/extensions.ts b/src/rules/extensions.ts index 319cb55c..f0c6fa35 100644 --- a/src/rules/extensions.ts +++ b/src/rules/extensions.ts @@ -329,8 +329,8 @@ export default createRule({ const resolvedPath = resolve(importPath, context) const extension = - path.extname(importPath)?.slice?.(1) || - path.extname(resolvedPath).slice(1) + path.extname(importPath).slice(1) || + (resolvedPath ? path.extname(resolvedPath).slice(1) : '') // determine if this is a module const isPackage =