Use value of object pattern instead of key for assignment checking. (close #26)

Author: benmosher

lib/rules/no-reassign.js

@@ -66,7 +66,9 @@ module.exports = function (context) {
     // todo: destructuring assignment
     'ObjectPattern': function (o) {
       o.properties.forEach(function (p) {
-        if (p.key.type === 'Identifier') checkIdentifier(p.key)
+        if (p.value.type === 'Identifier') checkIdentifier(p.value)
+        // apparently in `var { foo }`, this fills the key and value fields
+        // else if (p.key.type === 'Identifier') checkIdentifier(p.key)
       })
     },
 

tests/lib/rules/no-reassign.js

@@ -24,6 +24,10 @@ eslintTester.addRuleTest('lib/rules/no-reassign', {
          , ecmaFeatures: { destructuring: true } })
   , test({ code: 'var [, y] = ["foo", 42];'
          , ecmaFeatures: { destructuring: true } })
+
+    // valid destructuring
+  , test({ code: 'import * as foo from \'./bar\'; var { foo: bar } = {foo: 42};'
+         , ecmaFeatures: { destructuring: true, modules: true } })
   ],
 
   invalid: [
@@ -78,6 +82,11 @@ eslintTester.addRuleTest('lib/rules/no-reassign', {
       errors: [{ message: 'Reassignment of local imported name \'foo\'.'}],
       ecmaFeatures: {modules: true, destructuring: true}}),
 
+    test({
+      code: 'import { foo } from \'./bar\'; var { bar: foo } = { bar: \'y\' };',
+      errors: [{ message: 'Reassignment of local imported name \'foo\'.'}],
+      ecmaFeatures: {modules: true, destructuring: true}}),
+
     test({
       code: 'import { foo } from \'./bar\'; var [foo] = [\'y\'];',
       errors: [{ message: 'Reassignment of local imported name \'foo\'.'}],