Validate data types of fields upon receive (#94)

Author: KirIgor

CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [6.9.0] - 2025-10-02
+### Changed
+- Add check of data scalar types in order to provide readable error text.
+
 ## [6.8.0] - 2025-08-25
 ### Changed
 - Updated `rabbit_messaging` gem version to `1.7.0`

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    table_sync (6.8.0)
+    table_sync (6.9.0)
       memery
       rabbit_messaging (>= 1.7.0)
       rails

lib/table_sync/receiving/handler.rb

@@ -131,12 +131,20 @@ def validate_data(data, target_keys:)
     end
   end
 
+  def validate_data_types(model, data)
+    errors = model.validate_types(data)
+    return if errors.nil?
+
+    raise TableSync::DataError.new(data, errors.keys, errors.to_json)
+  end
+
   def perform(config, params)
     model = config.model
 
     model.transaction do
       results = if event == :update
                   config.before_update(**params)
+                  validate_data_types(model, params[:data])
                   model.upsert(**params)
                 else
                   config.before_destroy(**params)

lib/table_sync/receiving/model/active_record.rb

@@ -25,6 +25,7 @@ def initialize(table_name)
         self.table_name = table_name
         self.inheritance_column = nil
       end
+      @types_validator = TableSync::Utils::Schema::Builder::ActiveRecord.build(@raw_model)
 
       model_naming = ::TableSync::NamingResolver::ActiveRecord.new(table_name:)
 
@@ -105,6 +106,10 @@ def destroy(data:, target_keys:, version_key:)
       result
     end
 
+    def validate_types(data)
+      types_validator.validate(data)
+    end
+
     def transaction(&)
       ::ActiveRecord::Base.transaction(&)
     end
@@ -115,7 +120,7 @@ def after_commit(&)
 
     private
 
-    attr_reader :raw_model
+    attr_reader :raw_model, :types_validator
 
     def db
       raw_model.connection

lib/table_sync/receiving/model/sequel.rb

@@ -6,6 +6,7 @@ class Sequel
 
     def initialize(table_name)
       @raw_model = Class.new(::Sequel::Model(table_name)).tap(&:unrestrict_primary_key)
+      @types_validator = TableSync::Utils::Schema::Builder::Sequel.build(@raw_model)
 
       model_naming = ::TableSync::NamingResolver::Sequel.new(
         table_name:,
@@ -52,6 +53,10 @@ def destroy(data:, target_keys:, version_key:)
       result
     end
 
+    def validate_types(data)
+      types_validator.validate(data)
+    end
+
     def transaction(&)
       db.transaction(&)
     end
@@ -62,7 +67,7 @@ def after_commit(&)
 
     private
 
-    attr_reader :raw_model
+    attr_reader :raw_model, :types_validator
 
     def dataset
       raw_model.dataset

lib/table_sync/utils.rb

@@ -6,5 +6,6 @@ module Utils
     require_relative "utils/proc_keywords_resolver"
     require_relative "utils/interface_checker"
     require_relative "utils/required_validator"
+    require_relative "utils/schema"
   end
 end

lib/table_sync/utils/schema.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+# Next code checks that hash values have required data types
+
+require_relative "schema/builder"
+
+class TableSync::Utils::Schema
+  attr_reader :schema
+
+  def initialize(schema)
+    @schema = schema
+  end
+
+  def validate(data)
+    errors = nil
+    data.each do |row|
+      schema.each do |key, value|
+        if (error = value.validate(row[key]))
+          errors ||= {}
+          errors[key] = error
+        end
+      end
+
+      return errors.freeze unless errors.nil?
+    end
+    errors
+  end
+end

lib/table_sync/utils/schema/builder.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+require_relative "validator"
+require_relative "builder/sequel"
+require_relative "builder/active_record"

lib/table_sync/utils/schema/builder/active_record.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+class TableSync::Utils::Schema
+  module Builder
+    class ActiveRecord
+      class << self
+        Type = TableSync::Utils::Schema::Validator::Type
+
+        def build(model)
+          TableSync::Utils::Schema.new(schema(model))
+        end
+
+        private
+
+        def schema(model)
+          model.attribute_types.to_h do |key, value|
+            next [nil, nil] unless (type = type(value))
+            [key.to_sym, TableSync::Utils::Schema::Validator.new(type)]
+          end.tap(&:compact!)
+        end
+
+        def type(value)
+          case value
+          when ActiveModel::Type::String,
+               ActiveModel::Type::ImmutableString
+            Type::STRING
+          when ActiveModel::Type::DateTime,
+               ActiveModel::Type::Date,
+               ActiveModel::Type::Time
+            Type::DATETIME
+          when ActiveModel::Type::Integer
+            Type::INTEGER
+          when ActiveModel::Type::Decimal,
+               ActiveModel::Type::Float,
+               ActiveModel::Type::BigInteger
+            Type::DECIMAL
+          when ActiveModel::Type::Boolean
+            Type::BOOLEAN
+          end
+        end
+      end
+    end
+  end
+end

lib/table_sync/utils/schema/builder/sequel.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+class TableSync::Utils::Schema
+  module Builder
+    class Sequel
+      class << self
+        Type = TableSync::Utils::Schema::Validator::Type
+
+        def build(model)
+          TableSync::Utils::Schema.new(schema(model))
+        end
+
+        private
+
+        def schema(model)
+          model.db_schema.transform_values do |value|
+            next unless (type = type(value))
+            TableSync::Utils::Schema::Validator.new(type)
+          end.tap(&:compact!)
+        end
+
+        def type(value)
+          case value[:type]
+          when :string
+            Type::STRING
+          when :datetime, :date, :time
+            Type::DATETIME
+          when :integer
+            Type::INTEGER
+          when :decimal, :float
+            Type::DECIMAL
+          when :boolean
+            Type::BOOLEAN
+          end
+        end
+      end
+    end
+  end
+end