Discounts are not applied as expected

[nickfrederiksen]

Which component is this issue related to?

Umbraco Commerce (Core)

Which Umbraco Commerce version are you using? (Please write the exact version, example: 10.1.0)

16.3.0

Bug summary

Discounts seem to be ignored if there is a rule present.

Specifics

Given this configuration:

The "10% off"-reward is not being applied. At all.

This, however, does:

But it applies the discount to all products. Which is not what we want.

If I change the reward to use the "product order line reward":

The discount is not being applied either.

It doesn't matter if I select the variant, product or any ancestor-page. The discount is not being applied.

We have a similar setup in version 15.3.11 where discounts are applied as expected.

Steps to reproduce

1. Create pages for category -> product -> variant
2. Create a discount like described above.
3. Add variant to cart.
4. Observe no discount is applied.

Expected result / actual result

I expect the discount to be applied, that doesn't seem to be the case.

Dependencies

No response

[mattbrailsford]

I've managed to replicate this and have found where the issue lies. Seems we broke how UDI's are parsed at some point and so it was failing to resolve the category node and so was failing to correctly validate the product was in the category.

I've pushed a 16.3.1--preview.4 build to our nightly feed if you want to give that a try and see if it resolves your issue?

[nickfrederiksen]

Great, thanks! Will take a look first thing monday!