Allow to pass in CookieOptions when setting cookie

[bjarnef]

Looking at the cookie managers in Umbraco core, it seems it isn't possible to pass in CookieOptions?

E.g. SetCookieValue() in AspNetCoreCookieManager:

Umbraco-CMS/src/Umbraco.Web.Common/AspNetCore/AspNetCoreCookieManager.cs

Line 31 in dfde679

_httpContextAccessor.HttpContext?.Response.Cookies.Append(cookieName, value, new CookieOptions());

or if injecting ICookieManager:

Umbraco-CMS/src/Umbraco.Core/Web/ICookieManager.cs

Line 9 in dfde679

void SetCookieValue(string cookieName, string value);

Should it has an overload method of optional parameter to pass in CookieOptions?

[bergmania]

I don't like the idea of our interface exposing the CookieOptions as it is a third party model and our interfaces should not expose those.

I see three possible directions:

1. We make ICookieManager internal, as it really just is intended for us to handle cookies in the same way.
2. We expose a custom model, with a subset of the options that can be mapped to CookieOptions
3. We keep it as it is, and let people use it if it can benefit them and force people to handle complex cookie things them selves.

Personally I like 1) and 3) the most.

[bjarnef]

In a current project I tried used ICookieManager which does set/update the cookie, but always as session cookie since the expire date isn't set.

I solved it without using the ICookieManager instead as it didn't allow us to set expire date of the cookie.

if (newValue?.Any() == true)
{
    var cookieOptions = new Microsoft.AspNetCore.Http.CookieOptions()
    {
        Path = "/",
        HttpOnly = false,
        IsEssential = true,
        Expires = DateTime.Now.AddDays(1),
    };

    Context.Response.Cookies.Delete(cookieName);
    Context.Response.Cookies.Append(cookieName, string.Join(", ", newValue), cookieOptions);
}