Missing dimensions on Media after uSync

[netcompany-runeviumsondergaard]

Hello
I am using uSync to sync both content and media across my instances of Umbraco (and moving the wwwroot with the actual images in). Unfortunately it seems that the umbracoWidth, umbracoHeight etc. is not updated automatically, and will only be set after pushing the save button.

To handle this I made an UpdateMediaDimensionsHandler which looks through the media files and updates the images when the application is fully started and only on the first boot. It is tested on Umbraco 11.
The handler is added in the startup as a notification handler:
.AddNotificationHandler<UmbracoApplicationStartedNotification, UpdateMediaDimensionsHandler>()
I don't know if this should really be a bug reported to Umbraco or uSync, but now there is a fix which possible could become part of Umbraco :)

Code:

using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Events;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Notifications;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Infrastructure.Scoping;

namespace UmbracoPOC.Handlers;

public class UpdateMediaDimensionsHandler : INotificationHandler
{
private readonly IKeyValueService _keyValueService;
private readonly IMediaService _mediaService;
private readonly IMediaTypeService _mediaTypeService;
private readonly IScopeProvider _scopeProvider;

public UpdateMediaDimensionsHandler(IScopeProvider scopeProvider, IMediaService mediaService,
    IMediaTypeService mediaTypeService, IKeyValueService keyValueService)
{
    _scopeProvider = scopeProvider;
    _mediaService = mediaService;
    _mediaTypeService = mediaTypeService;
    _keyValueService = keyValueService;
}

public void Handle(UmbracoApplicationStartedNotification notification)
{
    using var scope = _scopeProvider.CreateScope();
    if (IsMediaDimensionsUpdated())
    {
        scope.Complete();
        return;
    }

    UpdateMediaDimensions();
    SetMediaDimensionsUpdatedFlag();

    scope.Complete();
}

private bool IsMediaDimensionsUpdated()
{
    var mediaDimensionsUpdated = _keyValueService.GetValue("MediaDimensionsUpdated");
    return mediaDimensionsUpdated != null && bool.TryParse(mediaDimensionsUpdated, out var updated) && updated;
}

private void UpdateMediaDimensions()
{
    var mediaTypeAliases = new[]
    { 
        Constants.Conventions.MediaTypes.Image, 
        Constants.Conventions.MediaTypes.VectorGraphicsAlias
    };

    foreach (var mediaTypeAlias in mediaTypeAliases) UpdateMediaDimensionsForMediaType(mediaTypeAlias);
}

private void UpdateMediaDimensionsForMediaType(string mediaTypeAlias)
{
    var mediaType = _mediaTypeService.Get(mediaTypeAlias);
    if (mediaType == null) return;

    var pageIndex = 0;
    const int pageSize = 100;
    long totalRecords;

    do
    {
        var mediaItems = _mediaService.GetPagedOfType(
            mediaType.Id,
            pageIndex,
            pageSize,
            out totalRecords,
            null,
            Ordering.By("Name"));

        foreach (var mediaItem in mediaItems) UpdateMediaDimensionIfRequired(mediaItem);

        pageIndex++;
    } while (pageIndex * pageSize < totalRecords);
}

private void UpdateMediaDimensionIfRequired(IMedia mediaItem)
{
    var width = mediaItem.GetValue<int?>(Constants.Conventions.Media.Width);
    var height = mediaItem.GetValue<int?>(Constants.Conventions.Media.Height);
    var bytes = mediaItem.GetValue<long>(Constants.Conventions.Media.Bytes);
    var extension = mediaItem.GetValue<string>(Constants.Conventions.Media.Extension);

    if (!width.HasValue || !height.HasValue || bytes == default || string.IsNullOrEmpty(extension))
        _mediaService.Save(mediaItem);
}

private void SetMediaDimensionsUpdatedFlag()
{
    _keyValueService.SetValue("MediaDimensionsUpdated", "true");
}

}