Add constants for property aliases to ModelsBuilder

[LennardF1989]

Right now, the only way to sanely retrieve property aliases is by using the information in the ImplementPropertyType-attribute. This has a runtime overhead because you will have to use reflection to get to it.

Please add constants for all aliases like you do with ModelTypeAlias.

The use case of this would be when you are working with an IContent, instead of an IPublishedContent.

[abjerner]

Wouldn't nameof(MyModel.MyProperty) suffice?

Anyways - based on past comments from Umbraco HQ, it doesn't seem like they are going to add new features to the build-in Models Builder. But if you can come up a good example on how to expose the property aliases, I'd be happy to add something like this to my custom Models Builder.

[bergmania]

Overall I like the idea :)

I dont see any issues by adding this to ModelsBuilder directly in the CMS.

Fundamentally I'm not for more configurations as the test matrix increases in size every time we add a new configuration. If we add it to Umbraco 11 and potentially Umbraco 10, I will be required to avoid conflicts, but I could be tempted to enable it by default from Umbraco 12.

[LennardF1989]

I'm fine with either :) The option would be for backwards compatibility.

[skttl]

Why not have it generate the constants in another namespace, eg Umbraco.Cms.Web.Common.PublishedConstants.{ContentTypeAlias}.{PropertyAlias}

[LennardF1989]

While a good idea, the whole point of this commit is to make the least changes to the ModelsBuilder possible, under the idea of Umbraco HQ not really wanting to do much more with it. Generating a whole additional set of files would certainly be a much bigger change, not too mention a partial repeat of code due to the loop through all ContentTypes and properties.

[bielu]

@bergmania when I saw this thread, I made comments in PR, as I think it is not great in long run, because of potential Collisions when generating, it is why I propose alternative approach to wrap it with PropertyWrapper with properties Value and Alias and I think it is cleaner and easier to maintain solution in long run :)
as mentioned in pr from @LennardF1989 I made POC
#14068
It didnt require much of changes, but it is POC I would need made same changes for properties coming from Mixins etc, but yeah it is just POC for now

[nul800sebastiaan]

Hey all! We've enjoyed and spent quite a bit of time all contemplating your feature wishes and the many varying opinions on what's the best solution.

After listening to your wishes, edge cases and possible conflicts in generating classes we came to the following conclusion:

• the opinions on the concrete implementation here are quite varied
• we have too few unit tests for Modelsbuilder to confidently make changes in generating models
• a LOT of the CMS relies on Modelsbuilder staying stable

Therefore, we'd like these kinds of changes to be tested out in the wild in a good variety of websites to see what works and what needs fixing up before it's reliable.

To that end, we've merged #12210 that will allow anyone to implement their own GenerateModels method. We'd love it if one/some of you would make a package for generating models differently and have that used by various projects to stabilize the new additions. Once we're more confident that a certain implementation works reliably we can reconsider looking at a pull request to have these proven changes added to the core models generator.

We definitely realize that this means copying a lot of our code into that generator but in the end we think this is best for the stability of the CMS.

And finally a thanks to everyone for chiming in here, we love the engagement!