Explicit set __NodeId property in index

[bjarnef]

It seems Umbraco implementation the __NodeId property is set based on id value passed into ValueSet ctor, which is confusing in a custom index.

E.g.

var course = model.Course;

var values = new Dictionary<string, IEnumerable<object>>()
{
	{ Constants.Examine.Common.FieldNames.Reference, new object[] { model.DocId }},
	{ Constants.Examine.FieldNames.HideFromSearch, NoValue },
	{ Umbraco.Cms.Infrastructure.Examine.UmbracoExamineFieldNames.ItemIdFieldName, new object[] { course.NodeId! }},
	{ Umbraco.Cms.Infrastructure.Examine.UmbracoExamineFieldNames.NodeNameFieldName, new object[] { course.Name! }},
	{ Constants.Examine.Course.FieldNames.CourseName, new object[] { course.Name! }},
	{ Constants.Examine.Course.FieldNames.CategoryId, new object[] { string.Join(" ", course.CategoryIds!) }},
	{ Constants.Examine.Course.FieldNames.BusinessId, new object[] { string.Join(" ", course.BusinessIds!) }},
};

var valueSet = new ValueSet(model.DocId, _category, _itemType, values);

when we also included Umbraco.Cms.Infrastructure.Examine.UmbracoExamineFieldNames.ItemIdFieldName (__NodeId) the indexed document shows this, which seems to be id combined with __NodeId :

using this instead shows only this id:

var values = new Dictionary<string, IEnumerable<object>>()
{
	{ Constants.Examine.Common.FieldNames.Reference, new object[] { model.DocId }},
	{ Constants.Examine.FieldNames.HideFromSearch, NoValue },
	{ Umbraco.Cms.Infrastructure.Examine.UmbracoExamineFieldNames.NodeNameFieldName, new object[] { course.Name! }},
	{ Constants.Examine.Course.FieldNames.CourseName, new object[] { course.Name! }},
	{ Constants.Examine.Course.FieldNames.CategoryId, new object[] { string.Join(" ", course.CategoryIds!) }},
	{ Constants.Examine.Course.FieldNames.BusinessId, new object[] { string.Join(" ", course.BusinessIds!) }},
};

var valueSet = new ValueSet(model.DocId, _category, _itemType, values);

However still a bit confusing since __NodeId property isn't set directly in value set builder.

We can index this instead (or where value of constamt Constants.Examine.Course.FieldNames.NodeId is id or courseId).
It seems Umbraco use id in the content valueset builder:

Umbraco-CMS/src/Umbraco.Infrastructure/Examine/ContentValueSetBuilder.cs

Line 80 in 33adbf4

{ "id", new object[] { c.Id } },

var values = new Dictionary<string, IEnumerable<object>>()
{
	{ Constants.Examine.Common.FieldNames.Reference, new object[] { model.DocId }},
	{ Constants.Examine.FieldNames.HideFromSearch, NoValue },
	{ Umbraco.Cms.Infrastructure.Examine.UmbracoExamineFieldNames.NodeNameFieldName, new object[] { course.Name! }},
	{ Constants.Examine.Course.FieldNames.NodeId, new object[] { course.NodeId! }},
	{ Constants.Examine.Course.FieldNames.CourseName, new object[] { course.Name! }},
	{ Constants.Examine.Course.FieldNames.CategoryId, new object[] { string.Join(" ", course.CategoryIds!) }},
	{ Constants.Examine.Course.FieldNames.BusinessId, new object[] { string.Join(" ", course.BusinessIds!) }},
};

var valueSet = new ValueSet(model.DocId, _category, _itemType, values);

Not sure if some logic by default set __NodeTypeAlias and __NodeId even when it is a custom implementation of IValueSetBuilder.

[bjarnef]

@Zeegaan @kjac do you have any idea why this happens? I would have expected it just just __NodeId property and the id passed into ValueSet is the document id?

Is there any reason it always set __NodeId and __NodeTypeAlias in a custom index?

[bergmania]

__NodeId, __NodeTypeAlias and __IndexType are constants in Examine too. I think the LuceneIndex which we inherit from sets it.