Need ability to filter members by group name in the backoffice

[saifobeidat]

In my case, we have a large number of members and we need sometimes to check if a member exists in a certain group or not.

so it would be a great feature if we can from the back office to list all members of particular group type by clicking [group name] and all related members will appear on the right side.

[nul800sebastiaan]

Sure it would be nice to have a paged list view in this overview containing the members with the selected role (member group). If anyone is thinking of picking this up then please note that the thing that I'm worried about (and why this might not have been done yet) is that querying for this data might be difficult and might not perform well, so that needs looking into.

[umbrabot]

Hi @saifobeidat,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

[cado1982]

@nul800sebastiaan I can take a stab at this one if you like.

There seems to already be GetByMemberGroup and a FindMembersInRole method in the MemberRepository. I think a group and a role is the same thing here. FindMemberInRole seems to have been build to support filtering for some UI view if I were to take a guess.

Umbraco-CMS/src/Umbraco.Core/Persistence/Repositories/IMemberRepository.cs

Lines 9 to 23 in 935690b

	/// <summary>
	/// Finds members in a given role
	/// </summary>
	/// <param name="roleName"></param>
	/// <param name="usernameToMatch"></param>
	/// <param name="matchType"></param>
	/// <returns></returns>
	IEnumerable<IMember> FindMembersInRole(string roleName, string usernameToMatch, StringPropertyMatchType matchType = StringPropertyMatchType.StartsWith);
	/// <summary>
	/// Get all members in a specific group
	/// </summary>
	/// <param name="groupName"></param>
	/// <returns></returns>
	IEnumerable<IMember> GetByMemberGroup(string groupName);

There's usages of both in the MemberService. In fact GetMembersInRole and GetMembersByGroup are identical

Umbraco-CMS/src/Umbraco.Core/Services/Implement/MemberService.cs

Lines 1003 to 1010 in 935690b

	public IEnumerable<IMember> GetMembersInRole(string roleName)
	{
	using (var scope = ScopeProvider.CreateScope(autoComplete: true))
	{
	scope.ReadLock(Constants.Locks.MemberTree);
	return _memberRepository.GetByMemberGroup(roleName);
	}
	}

Umbraco-CMS/src/Umbraco.Core/Services/Implement/MemberService.cs

Lines 497 to 504 in 935690b

	public IEnumerable<IMember> GetMembersByGroup(string memberGroupName)
	{
	using (var scope = ScopeProvider.CreateScope(autoComplete: true))
	{
	scope.ReadLock(Constants.Locks.MemberTree);
	return _memberRepository.GetByMemberGroup(memberGroupName);
	}
	}

Is there some historical difference between a MemberGroup and a Role here that I'm missing as a new contributor?

[nul800sebastiaan]

I believe those method exists for frontend usage, for example if you have an intranet and want to list members in the "UX" group or something. Member groups is just what Umbraco has called it for a long time but it's exactly the same as Roles, which is what the asp.net membership provider calls it.

I'd be happy for you to have a look of course but be aware that this has to be turned into paged lists, not just returning all members. For example, the Our Umbraco database has about 200000 registered members in it, so it might not perform very well.

I guess one of the methods GetMembersByGroup / GetMembersInRole exist for legacy reasons, not sure!

[enkelmedia]

I would agree with @nul800sebastiaan here =D However there is a concept of "Slim"-objects for other types (not sure about members) and maybe we can reuse this and not include any custom properties for the member as this is what would become slow =D

[umbrabot]

Hiya @saifobeidat,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[georgegoudie]

@umbrabot still relevant
This would be very useful for my project

[elit0451]

We are currently converting our feature requests to discussions, so even though this one has stalled, I would do the transfer to keep the discussion and link to a potential solution (the closed PR).