fix golangci-lint reported problems

Author: paskal

.github/workflows/ci.yml

@@ -36,7 +36,7 @@ jobs:
 
       - name: install golangci-lint and goveralls
         run: |
-          curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $GITHUB_WORKSPACE v1.41.1
+          curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $GITHUB_WORKSPACE v1.50.0
           GO111MODULE=off go get -u -v github.com/mattn/goveralls
       - name: run linters
         working-directory: backend

backend/.golangci.yml

@@ -9,37 +9,34 @@ run:
 linters:
   enable:
     - bodyclose
-    - deadcode
     - depguard
     - dogsled
     - dupl
-    - gas
     - errcheck
+    - exportloopref
+    - gas
     - gochecknoinits
     - goconst
     - gocritic
     - gocyclo
     - gofmt
     - goimports
-    - revive
     - goprintffuncname
-    - gochecknoinits
     - gosec
     - gosimple
     - govet
     - ineffassign
-    - misspell
     - megacheck
+    - misspell
     - nakedret
+    - revive
     - rowserrcheck
-    - exportloopref
     - staticcheck
-    - structcheck
     - stylecheck
     - typecheck
     - unconvert
     - unparam
     - unused
-    - varcheck
+    - unused
     - whitespace
   disable-all: true

backend/extractor/pics.go

@@ -1,7 +1,7 @@
 package extractor
 
 import (
-	"io/ioutil"
+	"io"
 	"net/http"
 	"sort"
 	"sync"
@@ -78,7 +78,7 @@ func (f UReadability) getImageSize(url string) (size int) {
 		}
 	}()
 
-	data, err := ioutil.ReadAll(resp.Body)
+	data, err := io.ReadAll(resp.Body)
 	if err != nil {
 		log.Printf("[WARN] failed to get %s, err=%v", url, err)
 		return 0

backend/extractor/readability.go

@@ -4,7 +4,7 @@ package extractor
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"net/url"
 	"regexp"
@@ -84,7 +84,7 @@ func (f UReadability) Extract(ctx context.Context, reqURL string) (rb *Response,
 	}()
 
 	rb.URL = resp.Request.URL.String()
-	dataBytes, e := ioutil.ReadAll(resp.Body)
+	dataBytes, e := io.ReadAll(resp.Body)
 
 	if e != nil {
 		log.Printf("[WARN] failed to read data from %s, error=%v", reqURL, e)

backend/extractor/readability_test.go

@@ -3,7 +3,6 @@ package extractor
 import (
 	"context"
 	"io"
-	"io/ioutil"
 	"log"
 	"net/http"
 	"net/http/httptest"
@@ -156,7 +155,7 @@ func TestGetContentCustom(t *testing.T) {
 	resp, err := httpClient.Get("https://p.umputun.com/2015/09/25/poiezdka-s-apple-maps/")
 	assert.NoError(t, err)
 	defer resp.Body.Close()
-	dataBytes, err := ioutil.ReadAll(resp.Body)
+	dataBytes, err := io.ReadAll(resp.Body)
 	assert.NoError(t, err)
 	body := string(dataBytes)
 

backend/extractor/text.go

@@ -1,7 +1,7 @@
 package extractor
 
 import (
-	"io/ioutil"
+	"io"
 	"log"
 	"net/http"
 	"strings"
@@ -89,7 +89,7 @@ func (f UReadability) toUtf8(content []byte, header http.Header) (contentType, o
 			log.Printf("[WARN] charset reader failed, %v", err)
 			return contentType, origEncoding, result
 		}
-		conv2utf8, err := ioutil.ReadAll(rr)
+		conv2utf8, err := io.ReadAll(rr)
 		if err != nil {
 			log.Printf("[WARN] convert to utf-8 failed, %b", err)
 			return contentType, origEncoding, result