Updating the schema adding new table. #233

nielsnl68 · 2021-07-01T10:28:46Z

nielsnl68
Jul 1, 2021

Hi,

I'm a little bit lost again with schema versioning and adding new tables.
i tried to add a new new table to my db. i updated the version and created the following:

    var tests = {
        name: 'tests',
        columns: {
            id: { primaryKey: true, autoIncrement: true },
            naam: { notNull: true, dataType: 'string', unique: true }
        },
        encrypt :"_dvad546fgu!qwdf"
    }

or:

    var tests = {
        name: 'tests',
        columns: {
            id: { primaryKey: true, autoIncrement: true },
            naam: { notNull: true, dataType: 'string', unique: true }
        },
        encrypt: "_dvad546fgu!qwdf",
        alter: {
            7: {
                add: {
                    id: { primaryKey: true, autoIncrement: true },
                    naam: { notNull: true, dataType: 'string', unique: true }
                }
            }
        }
    }

with this initDB:

    var db = {
        name: 'metingen',
        version: 8,
        tables: [gebruikers, metingen, tests]//
    }
    await jsstoreCon.initDb(db);

I getting the following error messages:

jsstore.worker.js:871 Uncaught DOMException: Failed to execute 'createIndex' on 'IDBObjectStore': An index with the specified name already exists.
addColumn @ jsstore.worker.js:871
(anonymous) @ jsstore.worker.js:900
(anonymous) @ jsstore.worker.js:899
dbOpenRequest.onupgradeneeded @ jsstore.worker.js:886
IndexedDB (async)
(anonymous) @ jsstore.worker.js:818
promise @ jsstore.worker.js:282
IDBUtil.initDb @ jsstore.worker.js:817
(anonymous) @ jsstore.worker.js:5519
promise @ jsstore.worker.js:282
QueryManager.initDb @ jsstore.worker.js:5518
QueryManager.executeQuery @ jsstore.worker.js:5304
(anonymous) @ jsstore.worker.js:5429
Promise.then (async)
QueryManager.run @ jsstore.worker.js:5428
self.onmessage @ jsstore.worker.js:5553
jsstore.worker.js:837 error Event {isTrusted: true, type: "error", target: IDBOpenDBRequest, currentTarget: IDBOpenDBRequest, eventPhase: 2, …}
dbOpenRequest.onerror @ jsstore.worker.js:837
error (async)
(anonymous) @ jsstore.worker.js:836
promise @ jsstore.worker.js:282
IDBUtil.initDb @ jsstore.worker.js:817
(anonymous) @ jsstore.worker.js:5519
promise @ jsstore.worker.js:282
QueryManager.initDb @ jsstore.worker.js:5518
QueryManager.executeQuery @ jsstore.worker.js:5304
(anonymous) @ jsstore.worker.js:5429
Promise.then (async)
QueryManager.run @ jsstore.worker.js:5428
self.onmessage @ jsstore.worker.js:5553
jsstore.worker.js:597 {message: "Version change transaction was aborted in upgradeneeded event handler.", type: "AbortError"}
LogHelper.logError @ jsstore.worker.js:597
getError @ jsstore.worker.js:958
(anonymous) @ jsstore.worker.js:5438
Promise.catch (async)
QueryManager.run @ jsstore.worker.js:5436
self.onmessage @ jsstore.worker.js:5553
index.js:2160 Uncaught (in promise) {message: "Version change transaction was aborted in upgradeneeded event handler.", type: "AbortError"}
initDb @ index.js:2160
async function (async)
initDb @ index.js:2159
(anonymous) @ index.js:580

ujjwalguptaofficial · 2021-07-01T14:16:23Z

ujjwalguptaofficial
Jul 1, 2021
Maintainer

Its because of you are adding the same column in alter query which is already added. This should be handled inside jsstore library, i will fix it.

But i m not able to understand, why you are adding the same column ?

3 replies

nielsnl68 Jul 1, 2021
Author

No no,

the error pop's up in both case's, with and without the alter part. In both cases the table is not created and the version stay's on the old version number

ujjwalguptaofficial Jul 1, 2021
Maintainer

I am not sure what's exactly the situation but its happening due to adding a column which already exist. I have fixed this in v - 4.3.3, please install it and let me know.

ujjwalguptaofficial Jul 1, 2021
Maintainer

In the fix - i am checking if column exist or not. If exist - do not create it.

nielsnl68 · 2021-07-01T14:37:40Z

nielsnl68
Jul 1, 2021
Author

Can you try this, while i'm testing the new version:

have a old working setup add the first version (without the alter) update the version and add the table to the database.

thats what i did at first then started to doubt meself :(

3 replies

ujjwalguptaofficial Jul 1, 2021
Maintainer

ok, will try to reproduce

nielsnl68 Jul 1, 2021
Author

Hmm, strange, just found out that setting the version number to from 7 to 8 i got error (while the table tests table was not added to the table list. Setting the version back to 7 the error is gone.

does that make any sense to you?

ujjwalguptaofficial Jul 2, 2021
Maintainer

yes error is happening during upgrade, but since there is error occuring in upgrade - transaction is being aborted.

nielsnl68 · 2021-07-01T14:45:45Z

nielsnl68
Jul 1, 2021
Author

And test is done. Sadly i have still the same error.

jsstore.worker.js:884 Uncaught DOMException: Failed to execute 'deleteIndex' on 'IDBObjectStore': The specified index was not found.
    at deleteColumn (.../jsstore.worker.js:884:23)
    at .../jsstore.worker.js:908:21
    at forObj (.../jsstore.worker.js:573:9)
    at .../jsstore.worker.js:907:19
    at Array.forEach (<anonymous>)
    at IDBOpenDBRequest.dbOpenRequest.onupgradeneeded (.../jsstore.worker.js:888:23)
deleteColumn @ jsstore.worker.js:884
(anonymous) @ jsstore.worker.js:908
forObj @ jsstore.worker.js:573
(anonymous) @ jsstore.worker.js:907
dbOpenRequest.onupgradeneeded @ jsstore.worker.js:888
IndexedDB (async)
(anonymous) @ jsstore.worker.js:819
promise @ jsstore.worker.js:282
IDBUtil.initDb @ jsstore.worker.js:818
(anonymous) @ jsstore.worker.js:5546
promise @ jsstore.worker.js:282
QueryManager.initDb @ jsstore.worker.js:5545
QueryManager.executeQuery @ jsstore.worker.js:5331
(anonymous) @ jsstore.worker.js:5456
Promise.then (async)
QueryManager.run @ jsstore.worker.js:5455
self.onmessage @ jsstore.worker.js:5580
jsstore.worker.js:838 error Event {isTrusted: true, type: "error", target: IDBOpenDBRequest, currentTarget: IDBOpenDBRequest, eventPhase: 2, …}
dbOpenRequest.onerror @ jsstore.worker.js:838
error (async)
(anonymous) @ jsstore.worker.js:837
promise @ jsstore.worker.js:282
IDBUtil.initDb @ jsstore.worker.js:818
(anonymous) @ jsstore.worker.js:5546
promise @ jsstore.worker.js:282
QueryManager.initDb @ jsstore.worker.js:5545
QueryManager.executeQuery @ jsstore.worker.js:5331
(anonymous) @ jsstore.worker.js:5456
Promise.then (async)
QueryManager.run @ jsstore.worker.js:5455
self.onmessage @ jsstore.worker.js:5580
jsstore.worker.js:598 {message: "Version change transaction was aborted in upgradeneeded event handler.", type: "AbortError"}
LogHelper.logError @ jsstore.worker.js:598
getError @ jsstore.worker.js:960
(anonymous) @ jsstore.worker.js:5465
Promise.catch (async)
QueryManager.run @ jsstore.worker.js:5463
self.onmessage @ jsstore.worker.js:5580
index.js:2160 Uncaught (in promise) {message: "Version change transaction was aborted in upgradeneeded event handler.", type: "AbortError"}
initDb @ index.js:2160
async function (async)
initDb @ index.js:2158
(anonymous) @ index.js:580

0 replies

nielsnl68 · 2021-07-01T14:47:02Z

nielsnl68
Jul 1, 2021
Author

BTW, i created the same table on a new db and that table works fine. It has to do with adding a table to an existing db.

2 replies

ujjwalguptaofficial Jul 1, 2021
Maintainer

were you expecting drop table at some time ? I mean you removed the table in some version and added again ?

nielsnl68 Jul 1, 2021
Author

Yes, i was just wanting to test the encrypt middleware. after the test i would have removed it. But that's not what i have done.

BTW i do not see the table in the db where this error is shown. Looking at the "Application" tab of the DevTools section.

ujjwalguptaofficial · 2021-07-02T02:28:58Z

ujjwalguptaofficial
Jul 2, 2021
Maintainer

@nielsnl68 you were right, there is issue occuring when adding table to existing database. Although error is different from what you are saying.

I have fixed this in v - 4.3.4. I hope this fixes the issue, let me know.

0 replies

Uh oh!

Updating the schema adding new table. #233

Uh oh!

Uh oh!

nielsnl68 Jul 1, 2021

Replies: 5 comments · 8 replies

Uh oh!

ujjwalguptaofficial Jul 1, 2021 Maintainer

Uh oh!

nielsnl68 Jul 1, 2021 Author

Uh oh!

ujjwalguptaofficial Jul 1, 2021 Maintainer

Uh oh!

Uh oh!

ujjwalguptaofficial Jul 1, 2021 Maintainer

Uh oh!

nielsnl68 Jul 1, 2021 Author

Uh oh!

ujjwalguptaofficial Jul 1, 2021 Maintainer

Uh oh!

nielsnl68 Jul 1, 2021 Author

Uh oh!

ujjwalguptaofficial Jul 2, 2021 Maintainer

Uh oh!

nielsnl68 Jul 1, 2021 Author

Uh oh!

nielsnl68 Jul 1, 2021 Author

Uh oh!

ujjwalguptaofficial Jul 1, 2021 Maintainer

Uh oh!

nielsnl68 Jul 1, 2021 Author

Uh oh!

ujjwalguptaofficial Jul 2, 2021 Maintainer

nielsnl68
Jul 1, 2021

Replies: 5 comments 8 replies

ujjwalguptaofficial
Jul 1, 2021
Maintainer

nielsnl68 Jul 1, 2021
Author

ujjwalguptaofficial Jul 1, 2021
Maintainer

ujjwalguptaofficial Jul 1, 2021
Maintainer

nielsnl68
Jul 1, 2021
Author

ujjwalguptaofficial Jul 1, 2021
Maintainer

nielsnl68 Jul 1, 2021
Author

ujjwalguptaofficial Jul 2, 2021
Maintainer

nielsnl68
Jul 1, 2021
Author

nielsnl68
Jul 1, 2021
Author

ujjwalguptaofficial Jul 1, 2021
Maintainer

nielsnl68 Jul 1, 2021
Author

ujjwalguptaofficial
Jul 2, 2021
Maintainer