fix max distance bug, iimog++ (v0.502)

Author: Nick Logan

Changes

@@ -1,6 +1,9 @@
 Revision history for Perl module Text::Levenshtein::XS
 
 {{$NEXT}}
+    - Fix max distance bug, iimog++
+
+0.501     2015-08-28 14:08:32-04:00 America/New_York
     - Manually add in version (Forgot how to use dzil + plugins)
 
 0.500     2015-08-28 13:56:18-04:00 America/New_York

Makefile.PL

@@ -35,7 +35,7 @@ my %WriteMakefileArgs = (
     "IPC::Open3" => 0,
     "Test::More" => 0
   },
-  "VERSION" => "0.501",
+  "VERSION" => "0.502",
   "test" => {
     "TESTS" => "t/*.t"
   }

README.mkdn

@@ -4,7 +4,7 @@ Text::Levenshtein::XS - Calculate edit distance based on insertion, deletion, su
 
 # VERSION
 
-version 0.501
+version 0.502
 
 # SYNOPSIS
 

XS.xs

@@ -52,6 +52,8 @@ PPCODE:
     }
 
     for (i=0; i < lenSource; i++) {
+        if( undef > 0 )
+            break;
 
         elem = sv_2mortal(av_shift(arraySource));
         s[i] = SvUV((SV *)elem);
@@ -70,10 +72,10 @@ PPCODE:
             /* v1[0] == index of current distance of v1 (i.e. v1[v1[0]] == current distance) */
             /* We also take diff into account so we can guess if current distance + length   */
             /* difference would push the total edit distance over the max distance           */
-            if( v1[0] == j && (mdx+1) < ((diff > v1[j]) ? (diff - v1[j]) : (diff + v1[j])) ) {
-                undef = 1;
-                break;
-            }
+            if( v1[0] == j )
+                if( mdx < ((diff > v1[j]) ? (diff - v1[j]) : (diff + v1[j])) )
+                    if( mdx > v1[j] )
+                        undef = 1;
         }
 
 

dist.ini

@@ -3,7 +3,7 @@ author           = ugexe <ugexe@cpan.org>
 license          = Perl_5
 copyright_holder = Nick Logan
 main_module      = lib/Text/Levenshtein/XS.pm
-version          = 0.501
+version          = 0.502
 
 [ReportPhase / Phase_Begins]            ; report on everything
 

lib/Text/Levenshtein/XS.pm

@@ -7,7 +7,7 @@ require Exporter;
 
 @Text::Levenshtein::XS::ISA       = qw/Exporter/;
 @Text::Levenshtein::XS::EXPORT_OK = qw/distance/;
-$Text::Levenshtein::XS::VERSION   = 0.501;
+$Text::Levenshtein::XS::VERSION   = 0.502;
 
 eval {
     require XSLoader;

t/02_distance.t

@@ -73,6 +73,7 @@ subtest 'Testing previous bugs/issues' => sub {
 
     is( distance('ACGTAG', 'AGTAG', 2), 1,     'iimog https://github.com/ugexe/Text--Levenshtein--XS/issues/10' );
     is( distance('ACGTAG', 'TCGG',  2), undef, 'iimog https://github.com/ugexe/Text--Levenshtein--XS/issues/10' );
+    is( distance('ACGTAG', 'AGTAG', 1), 1,     'iimog https://github.com/ugexe/Text--Levenshtein--XS/issues/11' );
 };
 
 # Not quite supported yet