Skip to content

The conditional check in datatransfer does not validate whether the required transfer_id is set #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rasmunk opened this issue Apr 16, 2025 · 0 comments
Open

The conditional check in datatransfer does not validate whether the required transfer_id is set #228

rasmunk opened this issue Apr 16, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@rasmunk
Copy link
Contributor

rasmunk commented Apr 16, 2025 •
edited
Loading

When the transfer_map is loaded in datatransfer.py via

migrid-sync/mig/shared/functionality/datatransfer.py

Line 750 in e1896df

transfer_dict = transfer_map.get(transfer_id, {})

The subsequent conditional check does not validate whether the transfer_id is actually present in the transfer_map since the following conditional check in both the action == 'deltransfer'

migrid-sync/mig/shared/functionality/datatransfer.py

Line 752 in e1896df

if transfer_dict is None:

and action == 'redotransfer'

migrid-sync/mig/shared/functionality/datatransfer.py

Line 761 in e1896df

if transfer_dict is None:

will never be true since an empty collection's truth value is false.

https://stackoverflow.com/questions/23177439/how-to-check-if-a-dictionary-is-empty
https://docs.python.org/3.8/library/stdtypes.html#truth-value-testing

Might be a leftover from python2
rasmunk added a commit that referenced this issue Apr 16, 2025
@rasmunk
Implement a fix to the issue raised in #228
c779e76
@rasmunk rasmunk mentioned this issue Apr 16, 2025
Closed
@jonasbardino jonasbardino linked a pull request Apr 23, 2025 that will close this issue
Implement a fix to the issue raised in #228 #229
Closed
@jonasbardino jonasbardino added the bug Something isn't working label Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement a fix to the issue raised in #228 ucphhpc/migrid-sync
2 participants
@jonasbardino @rasmunk