Split out the response data decoding chunk.

Author: albu-diku

tests/test_mig_services_coreapi.py

@@ -31,6 +31,21 @@
     from urllib.request import urlopen, Request
 
 
+def attempt_to_decode_response_data(data, response_encoding=None):
+    if response_encoding == 'textual':
+        data = codecs.decode(data, 'utf8')
+
+        try:
+            return json.loads(data)
+        except Exception as e:
+            return data
+    elif response_encoding == 'binary':
+        return data
+    else:
+        raise AssertionError(
+            'issue_POST: unknown response_encoding "%s"' % (response_encoding,))
+
+
 class MigServerGrid_openid(MigTestCase, HtmlAssertMixin):
     def before_each(self):
         self.server_addr = None
@@ -108,18 +123,8 @@ def issue_POST(self, request_path, request_data=None, request_json=None, respons
             status = httpexc.code
             data = httpexc.file.read()
 
-        if response_encoding == 'textual':
-            data = codecs.decode(data, 'utf8')
-
-            try:
-                data = json.loads(data)
-            except Exception as e:
-                pass
-        elif response_encoding != 'binary':
-            raise AssertionError(
-                'issue_POST: unknown response_encoding "%s"' % (response_encoding,))
-
-        return (status, data)
+        content = attempt_to_decode_response_data(data, response_encoding)
+        return (status, content)
 
     @unittest.skipIf(PY2, "Python 3 only")
     def test__GET_returns_not_found_for_missing_path(self):