Skip to content

Commit 246663b

Browse files
committed
Manually merge PR123 to address a python3-specific bug in edituser and editgdpuser as reported by AU.
git-svn-id: svn+ssh://svn.code.sf.net/p/migrid/code/trunk@6141 b75ad72c-e7d7-11dd-a971-7dbc132099af
1 parent ac523dd commit 246663b

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

mig/server/editgdpuser.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# --- BEGIN_HEADER ---
55
#
66
# editgdpuser - Edit a MiG GDP user
7-
# Copyright (C) 2003-2022 The MiG Project lead by Brian Vinter
7+
# Copyright (C) 2003-2024 The MiG Project lead by Brian Vinter
88
#
99
# This file is part of MiG.
1010
#
@@ -146,9 +146,9 @@ def usage(name='editgdpuser.py'):
146146
sys.exit(1)
147147

148148
# Remove empty value fields
149-
150-
for (key, val) in user_dict.items():
151-
if not val:
149+
# NOTE: force list copy here as we delete inline below
150+
for key in list(user_dict):
151+
if not user_dict[key]:
152152
del user_dict[key]
153153

154154
if account_state:

mig/server/edituser.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# --- BEGIN_HEADER ---
55
#
66
# edituser - Edit a MiG user
7-
# Copyright (C) 2003-2022 The MiG Project lead by Brian Vinter
7+
# Copyright (C) 2003-2024 The MiG Project lead by Brian Vinter
88
#
99
# This file is part of MiG.
1010
#
@@ -167,9 +167,9 @@ def usage(name='edituser.py'):
167167
user_dict['role'] = role
168168

169169
# Remove empty value fields
170-
171-
for (key, val) in user_dict.items():
172-
if not val:
170+
# NOTE: force list copy here as we delete inline below
171+
for key in list(user_dict):
172+
if not user_dict[key]:
173173
del user_dict[key]
174174

175175
if verbose:

0 commit comments

Comments
 (0)