Skip to content

Commit 1da80cc

Browse files
committed
Manually merge 136 to add storage_protocol support in generateconfs and address some unwanted side-effects identified around output_objects, environ and configuration defaults.
git-svn-id: svn+ssh://svn.code.sf.net/p/migrid/code/trunk@6154 b75ad72c-e7d7-11dd-a971-7dbc132099af
1 parent 4570ef0 commit 1da80cc

9 files changed

+915
-30
lines changed

mig/install/MiGserver-template.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ mig_server_id = %(server_fqdn)s.0
187187
empty_job_name = no_grid_jobs_in_grid_scheduler
188188
notify_protocols = email
189189
smtp_server = __SMTP_SERVER__
190+
storage_protocols = __STORAGE_PROTOCOLS__
190191
gdp_email_notify = __GDP_EMAIL_NOTIFY__
191192

192193
# Optional extra service interfaces with common structure

mig/shared/configuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ def fix_missing(config_file, verbose=True):
619619
'scriptlanguages': [],
620620
'jobtypes': [],
621621
'lrmstypes': [],
622-
'storage_protocols': ['sftp'],
622+
'storage_protocols': [],
623623
'server_cert': '',
624624
'server_key': '',
625625
'passphrase_file': '',

mig/shared/functionality/cat.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,17 +98,23 @@ def main(client_id, user_arguments_dict, environ=None):
9898
(configuration, logger, output_objects, op_name) = \
9999
initialize_main_variables(client_id)
100100

101-
return _main(configuration, logger, op_name=op_name,
101+
return _main(configuration, logger, environ, op_name=op_name,
102102
output_objects=output_objects, client_id=client_id,
103103
user_arguments_dict=user_arguments_dict)
104104

105105

106-
def _main(configuration, logger, op_name='', output_objects=[], client_id=None,
107-
user_arguments_dict=None, environ=None):
106+
def _main(configuration, logger, environ, op_name='', output_objects=None, client_id=None,
107+
user_arguments_dict=None):
108108
"""Actual main function to generate contents for the front end"""
109+
110+
assert environ is not None, "required arg: environ"
111+
109112
if logger is None:
110113
logger = configuration.logger
111114

115+
if output_objects is None:
116+
output_objects = [] # create a new list if one was not supplied
117+
112118
client_dir = client_id_dir(client_id)
113119
defaults = signature()[1]
114120
status = returnvalues.OK

0 commit comments

Comments
 (0)