Skip to content

Commit 069c93d

Browse files
committed
Switch over py2 lint from running on mock rocky8 on ubuntu-22.04 to running on
proper rocky8 through a container.
1 parent 0b98f9f commit 069c93d

File tree

1 file changed

+0
-33
lines changed

1 file changed

+0
-33
lines changed

.github/workflows/python-sanity-check.yml

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -13,39 +13,6 @@ permissions:
1313
contents: read
1414

1515
jobs:
16-
lint-python2-rocky8ish:
17-
runs-on: ubuntu-22.04
18-
steps:
19-
- uses: actions/checkout@v4
20-
# NOTE: python-2 is no longer supported here - try with apt
21-
- name: Set up Python 2.7 with APT and link to default
22-
run: |
23-
sudo apt install -y python2 python-pip
24-
- name: Install dependencies
25-
run: |
26-
python2 -m pip install --upgrade pip
27-
pip2 install flake8 pytest
28-
if [ -f requirements.txt ]; then pip2 install -r requirements.txt; fi
29-
- name: Lint with flake8
30-
run: |
31-
# TODO: fix unittest dir and remove from excludes
32-
# TODO: fix or migrate legacy grsfs-fuse dir and remove from excludes
33-
# TODO: should tests be included here - currently fail on py3-only FileNotFoundError, etc.
34-
# stop the build if there are Python syntax errors or undefined names
35-
flake8 . --exclude=tests,state,envhelp,fixture,output,unittest,grsfs-fuse,irclib.py,seafile-seahub_settings-template.py --count --select=E9,F63,F7,F82 --show-source --statistics
36-
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
37-
flake8 . --exclude=tests,state,envhelp,fixture,output,unittest,grsfs-fuse,vm-proxy,irclib.py,seafile-seahub_settings-template.py --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
38-
# NOTE: for interactive clean up one can use current ignores
39-
# E501 Ignore long lines, E402 imports below top, E722 bare except,
40-
# F401 unused imports, F502 explicit list in str expand, F841 unused var,
41-
# E721 compare type instead of isinstance, W293 blank line with space,
42-
# C901 too complex get
43-
#flake8 mig --exclude=unittest,grsfs-fuse,vm-proxy,irclib.py,seafile-seahub_settings-template.py --ignore=E501,E402,E722,F401,F502,E713,F841,C901 --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
44-
# TODO: prepare and enable pytest
45-
#- name: Test with pytest
46-
# run: |
47-
# pytest
48-
4916
lint-python2-rocky8:
5017
runs-on: ubuntu-22.04
5118
container:

0 commit comments

Comments
 (0)