Incomplete device configs are not prompting the user to enter lock code

[pajlow]

In the installer repo we get a lot of issues like ubports/ubports-installer#2831 (comment).
This is mainly happening to users with Xiaomi devices because they require an unlock code to unlock the bootloader. I went through some of the device configs and recognized that

handlers:
  bootloader_locked:
    actions:
      - fastboot:oem_unlock:

is implemented but without the field code_url: "someurl" they get no input to enter the code. Which causes the unlock to fail.
Of course you can prompt the user to unlock the device before he even starts the install but this case should be handled properly.
One solution would be to add those missing field. (I don't know if all vendors are providing codes - other tools might be needed)

[maciek134]

A lot of vendors are not using unlock codes. Are you suggesting showing the prompt without the code_url (something like show_prompt?), or going through device configs and adding the url where needed?

[pajlow]

For devices that allow unlock codes I would suggest adding the missing field. I am confused with Xiaomi though. @NotKit provided this URL https://en.miui.com/unlock/ in his unlock step which returns text files with random naming (unlock codes?).
But we need to somehow verify this actually works.
Another why would be to tell the user what actually went wrong in some error message with some follow up action.

[maciek134]

That's a weird url, maybe they changed it, before you could download the software there - afaik Xiaomi requires the use of their (Windows only) tool to unlock the bootloader and you don't actually see the code, but it's been a while since I unlocked one so maybe something changed or I didn't notice.

[amartinz]

I think the new URL is: https://en.miui.com/unlock/download_en.html