Skip to content

Double check stackallocs #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
durban opened this issue Apr 5, 2025 · 0 comments
Open

Double check stackallocs #4358

durban opened this issue Apr 5, 2025 · 0 comments
Milestone
v3.7.0

Comments

@durban
Copy link
Contributor

durban commented Apr 5, 2025

In #4201 there were multiple stackalloc[Type] calls which needed to be replaced by something like stackalloc[Byte](explicitSize).asInstanceOf[Ptr[Type]] (because otherwise they caused segfaults). However not all of them were replaced. We should double check the remaining ones, to determine whether they're compiled correctly, or not (and just happen not to segfault).

At least the following ones remained:

  • KqueueSystem: stackalloc[timespec]
  • WorkStealingThreadPoolPlatform: stackalloc[timespec]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
Development

No branches or pull requests
1 participant
@durban