Skip to content

Find a way to DRY up the IOApps #4333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djspiewak opened this issue Mar 30, 2025 · 4 comments · May be fixed by #4361
Open

Find a way to DRY up the IOApps #4333

djspiewak opened this issue Mar 30, 2025 · 4 comments · May be fixed by #4361
Assignees

Comments

@djspiewak
Copy link
Member

Somewhat of a follow up from #4201, though this has been a problem for a long time.

Basically all of the IOApps are very similar (especially JVM and Native), with just a few differences sprinkled throughout, some different documentation, and a few platform-specific APIs. We should try really hard to consolidate the actual code if we can because it's starting to get hard to maintain, especially between JVM and Native.

@kapunga
Copy link
Contributor

kapunga commented Apr 2, 2025

Do you mind if I take a crack at this?

@djspiewak
Copy link
Member Author

Go for it! Make sure to double-check mimaReportBinaryIssues, since that's where the trickiness is likely to be (CI will also run this for you, so any PR won't build if bincompat is broken).

@armanbilge
Copy link
Member

@kapunga @djspiewak maybe should wait until #4201 is merged, since that changes IOApp on the Native side? Or at least work on that branch?

@kapunga kapunga linked a pull request Apr 6, 2025 that will close this issue
@kapunga
Copy link
Contributor

kapunga commented Apr 6, 2025

I've started working on a draft PR. It's got a ways to go and I'm happy with the approach I'm taking, but if you are super opinionated, you may want to have a look-see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants