Skip to content

Commit 7a7bc1d

Browse files
authored
Add stub for django.db.models.expressions.Expression.identity (#2685)
I don't think we need to be very specific about the contents of the returned tuple; it's just used for comparison and hashing methods.
1 parent 1384300 commit 7a7bc1d

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

django-stubs/db/models/expressions.pyi

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,9 @@ class BaseExpression:
118118
def select_format(self, compiler: SQLCompiler, sql: str, params: _ParamsT) -> _AsSqlType: ...
119119
def get_expression_for_validation(self) -> BaseExpression: ...
120120

121-
class Expression(_Deconstructible, BaseExpression, Combinable): ...
121+
class Expression(_Deconstructible, BaseExpression, Combinable):
122+
@cached_property
123+
def identity(self) -> tuple[Any, ...]: ...
122124

123125
class CombinedExpression(SQLiteNumericMixin, Expression):
124126
connector: str

scripts/stubtest/allowlist_todo.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ django.contrib.gis.db.models.DurationField.formfield
173173
django.contrib.gis.db.models.DurationField.get_db_converters
174174
django.contrib.gis.db.models.EmailField.formfield
175175
django.contrib.gis.db.models.Exists.empty_result_set_value
176-
django.contrib.gis.db.models.Expression.identity
177176
django.contrib.gis.db.models.ExpressionWrapper.allowed_default
178177
django.contrib.gis.db.models.Extent.is_extent
179178
django.contrib.gis.db.models.Extent3D.is_extent
@@ -520,7 +519,6 @@ django.db.models.DurationField.formfield
520519
django.db.models.DurationField.get_db_converters
521520
django.db.models.EmailField.formfield
522521
django.db.models.Exists.empty_result_set_value
523-
django.db.models.Expression.identity
524522
django.db.models.ExpressionWrapper.allowed_default
525523
django.db.models.Field.__copy__
526524
django.db.models.Field.__deepcopy__
@@ -662,7 +660,6 @@ django.db.models.expressions.Func.allowed_default
662660
django.db.models.expressions.When.allowed_default
663661
django.db.models.expressions.Col.relabeled_clone
664662
django.db.models.expressions.Exists.empty_result_set_value
665-
django.db.models.expressions.Expression.identity
666663
django.db.models.expressions.OrderBy.as_oracle
667664
django.db.models.expressions.OrderBy.as_sql
668665
django.db.models.expressions.Ref.relabeled_clone

0 commit comments

Comments
 (0)