Expansion of "lift" concept #11
chris-martin
started this conversation in
Ideas
Replies: 1 comment
-
Documentation change is made, I think this okay now. https://github.com/typeclasses/ascii/releases/tag/ascii-superset-1.0.1.13 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I put the polymorphic
lift
function into theascii-superset
package as a general way to raise ASCII types into larger character sets, e.g.[ASCII.Char] -> Text
, so it could be a short memorable name for what I figure is a common operation. What I'm finding now as I'm introducing ASCII subset types, though, is that I also want to use this class for ASCII subsets.The definition currently looks like this:
There's nothing stopping us from going ahead and defining instances e.g.
instance Lift [HexChar] [ASCII.Char]
, but then the documentation really needs updating. And it then becomes sort of awkward for theLift
class to be in theascii-superset
package. Because, for instance,instance Lift D10 D16
seems perfectly okay, but it has nothing to do with ASCII supersets, since it only represents a lifting from one ASCII subset to another. I don't think it makes any sense to putLift
into its own package. It is possible that this is merely a documentation issue, and that theascii-superset
package description would just need to be updated along with theLift
class to convey that it also provides a bit of mechanism for talking about subsets.Beta Was this translation helpful? Give feedback.
All reactions