Skip to content

Commit 174a433

Browse files
committed
Increase subuser permission test coverage
1 parent 4ffc371 commit 174a433

File tree

1 file changed

+8
-20
lines changed

1 file changed

+8
-20
lines changed

src/test/java/org/twonote/rgwadmin4j/impl/RgwAdminImplTest.java

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -334,28 +334,16 @@ public void setSubUserPermission() throws Exception {
334334
testWithASubUser(
335335
su -> {
336336
SubUser subUser = su.getSubusers().get(0);
337-
SubUser.Permission permissionToSet;
338-
List<SubUser> response;
339-
SubUser result;
340337

341-
// basic
342-
permissionToSet = SubUser.Permission.READ;
343-
response =
344-
RGW_ADMIN.setSubUserPermission(
345-
subUser.getParentUserId(), subUser.getRelativeSubUserId(), permissionToSet);
346-
347-
result =
348-
response.stream().filter(r -> subUser.getId().equals(r.getId())).findFirst().get();
349-
assertEquals(permissionToSet, result.getPermission());
338+
for (SubUser.Permission permissionToSet : SubUser.Permission.values()) {
339+
List<SubUser> response =
340+
RGW_ADMIN.setSubUserPermission(
341+
subUser.getParentUserId(), subUser.getRelativeSubUserId(), permissionToSet);
350342

351-
// none
352-
permissionToSet = SubUser.Permission.NONE;
353-
response =
354-
RGW_ADMIN.setSubUserPermission(
355-
subUser.getParentUserId(), subUser.getRelativeSubUserId(), permissionToSet);
356-
result =
357-
response.stream().filter(r -> subUser.getId().equals(r.getId())).findFirst().get();
358-
assertEquals(permissionToSet, result.getPermission());
343+
SubUser result =
344+
response.stream().filter(r -> subUser.getId().equals(r.getId())).findFirst().get();
345+
assertEquals(permissionToSet, result.getPermission());
346+
}
359347
});
360348
}
361349

0 commit comments

Comments
 (0)