Use HttpClientFactory.

Author: twitchax

README.md

@@ -25,10 +25,20 @@ Latest .NET Standard 2.0.
 
 ### Examples
 
+First, you must add the required services.
+
+```csharp
+public void ConfigureServices(IServiceCollection services)
+{
+    ...
+    services.AddProxies();
+    ...
+}
+```
+
 #### Existing Controller
 
 You can use the proxy functionality on an existing `Controller` by leveraging the `Proxy` extension method.
-If this is the only feature that you use, then you do not need to configure anything in `Configure` and `ConfigureServices`.
 
 ```csharp
 public class MyController : Controller
@@ -54,12 +64,17 @@ app.UseProxy("api/{arg1}/{arg2}", async (args) => {
 
 #### `ProxyRoute` Attribute
 
-You can also make the proxy look and feel almost like a route.
+You can also make the proxy look and feel almost like a route, but as part of a static method.
 
-In your `Configure(IApplicationBuilder, IHostingEnvironment)` method, add the middleware.
+First, add the middleware.
 
 ```csharp
-app.UseProxies();
+public void Configure(IApplicationBuilder app, IHostingEnvironment env)
+{
+    ...
+    app.UseProxies();
+    ...
+}
 ```
 
 Then, create a static method which returns a `Task<string>` or `string` (where the `string` is the URI to proxy).

src/Core/AspNetCore.Proxy.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <Version>1.4.1</Version>
+    <Version>2.0.0</Version>
     <AssemblyName>AspNetCore.Proxy</AssemblyName>
     <PackageId>AspNetCore.Proxy</PackageId>
     <DocumentationFile>bin\AspNetCore.Proxy.xml</DocumentationFile>
@@ -10,5 +10,6 @@
     <PackageReference Include="Microsoft.AspNetCore" Version="2.0.0" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.0.0" />
     <PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Http" Version="2.2.0" />
   </ItemGroup>
 </Project>

src/Core/Helpers.cs

@@ -6,6 +6,7 @@
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Routing;
+using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyModel;
 
 namespace AspNetCore.Proxy
@@ -84,7 +85,11 @@ private static HttpRequestMessage CreateProxyHttpRequest(this HttpContext contex
         internal static Task<HttpResponseMessage> SendProxyHttpRequest(this HttpContext context, string proxiedAddress)
         {
             var proxiedRequest = context.CreateProxyHttpRequest(proxiedAddress);
-            return new HttpClient().SendAsync(proxiedRequest, HttpCompletionOption.ResponseHeadersRead, context.RequestAborted);
+
+            return context.RequestServices
+                .GetService<IHttpClientFactory>()
+                .CreateClient()
+                .SendAsync(proxiedRequest, HttpCompletionOption.ResponseHeadersRead, context.RequestAborted);
         }
 
         internal static async Task CopyProxyHttpResponse(this HttpContext context, HttpResponseMessage responseMessage)

src/Core/ProxyRouteExtensions.cs

@@ -7,6 +7,7 @@
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.Routing;
+using Microsoft.Extensions.DependencyInjection;
 
 namespace AspNetCore.Proxy
 {
@@ -31,6 +32,16 @@ public static Task ProxyAsync(this Controller controller, string uri, Func<HttpC
             return Helpers.HandleProxy(controller.HttpContext, uri, onFailure);
         }
 
+        /// <summary>
+        /// Adds the required services needed for proxying requests.
+        /// </summary>
+        /// <param name="services">The application service collection.</param>
+        /// <returns>The same instance.</returns>
+        public static IServiceCollection AddProxies(this IServiceCollection services)
+        {
+            return services.AddHttpClient();
+        }
+
         /// <summary>
         /// Middleware which instructs the runtime to detect static methods with [<see cref="ProxyRouteAttribute"/>] and route them.
         /// </summary>

src/Test/UnitTests.cs

@@ -141,6 +141,7 @@ public class Startup
         public void ConfigureServices(IServiceCollection services)
         {
             services.AddRouting();
+            services.AddProxies();
             services.AddMvc();
         }