Cleanup

Author: twistedfall

Cargo.toml

@@ -46,8 +46,9 @@ vcpkg = "0.2.9"
 
 [dev-dependencies]
 matches = "0.1"
+# copy of build-dependencies because we need to test methods of the build script
 opencv-binding-generator = { version = "0.93.0", path = "binding-generator" }
-cc = { version = ">=1.0.83", features = ["parallel"] }
+cc = { version = "1.0.83", features = ["parallel"] }
 dunce = "1"
 # jobserver-0.1.25 is the first one that has Client::available() method
 jobserver = "0.1.25"

README.md

@@ -142,6 +142,8 @@ The following variables affect the building the of the `opencv` crate, but belon
   ```
   opencv = { version = ..., default-features = false, features = ["calib3d", "features2d", "flann"]}
   ```
+* `clang-runtime` - enables the runtime detection of libclang (`runtime` feature of `clang-sys`). Useful as a
+  workaround for when your dependencies (like `bindgen`) pull in `clang-sys` with hard `runtime` feature.
 * `rgb` - allow using [`rgb`](https://crates.io/crates/rgb) crate types as `Mat` elements
 
 ## API details

binding-generator/src/lib.rs

@@ -6,6 +6,7 @@
 // fixme vector<Mat*> get's interpreted as Vector<Mat> which should be wrong (e.g. Layer::forward and Layer::apply_halide_scheduler)
 // fixme MatConstIterator::m return Mat**, is it handled correctly?
 // fixme VectorOfMat::get allows mutation
+// fixme MatSize looks like just a pointer inside a Mat so it should take a lifetime
 
 // copy-pasted form python generator (may be obsolete):
 // fixme returning MatAllocator (trait) by reference is bad, check knearestneighbour

build.rs

@@ -364,20 +364,14 @@ fn main() -> Result<()> {
 		eprintln!("===   {v} = {:?}", env::var_os(v));
 	}
 	eprintln!("=== Enabled features:");
-	let features = env::vars().filter_map(|(mut name, val)| {
-		if val != "1" {
-			return None;
-		}
-		const PREFIX: &str = "CARGO_FEATURE_";
-		if name.starts_with(PREFIX) {
-			name.drain(..PREFIX.len());
-			Some(name)
-		} else {
-			None
+	for (mut name, val) in env::vars() {
+		if val == "1" {
+			const PREFIX: &str = "CARGO_FEATURE_";
+			if name.starts_with(PREFIX) {
+				name.drain(..PREFIX.len());
+				eprintln!("===   {name}");
+			}
 		}
-	});
-	for feature in features {
-		eprintln!("===   {feature}");
 	}
 
 	let opencv = Library::probe()?;

src/lib.rs

@@ -1,5 +1,11 @@
 #![allow(rustdoc::broken_intra_doc_links)]
-
+/// Rust bindings for the OpenCV computer vision library
+///
+/// [Git](https://github.com/twistedfall/opencv-rust) | [Readme](https://github.com/twistedfall/opencv-rust/blob/master/README.md) |
+/// [Docs](https://docs.rs/opencv) | [Sponsor](https://github.com/sponsors/twistedfall)
+///
+/// Please note that this documentation is automatically generated from the C++ headers. So expect references to C++ items,
+/// code examples in C++ and other strange things.
 pub use error::{Error, Result};
 
 pub use crate::opencv::hub::*;