Skip to content

Commit c7862ed

Browse files
authored
chore: DI-1565 test case (#599)
* [DI-1565] update user agent string format to allow extension and its test cases * [DI-1565] update test case * [DI-1565] update deepsource config test pattern * [DI-1565] undo changes in deepsource config file * modify test cases to test for format
1 parent 128775b commit c7862ed

File tree

1 file changed

+6
-19
lines changed

1 file changed

+6
-19
lines changed

tests/unit/rest/test_client.py

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -110,25 +110,12 @@ def tearDown(self):
110110
def test_set_default_user_agent(self):
111111
self.client.request('GET', 'https://api.twilio.com/')
112112
request_header = self.client.http_client.last_request.headers['User-Agent']
113-
expected_user_agent = 'twilio-python/{} ({} {}) Python/{}'.format(
114-
__version__,
115-
platform.system(),
116-
platform.machine(),
117-
platform.python_version(),
118-
)
119-
self.assertEqual(request_header, expected_user_agent)
113+
self.assertRegex(request_header, r'^twilio-python\/[0-9.]+\s\(\w+\s\w+\)\sPython\/[^\s]+$')
120114

121115
def test_set_user_agent_extensions(self):
122-
user_agent_extensions = ['twilio-run/2.0.0-test', 'flex-plugin/3.4.0']
123-
self.client.user_agent_extensions = user_agent_extensions
116+
expected_user_agent_extensions = ['twilio-run/2.0.0-test', 'flex-plugin/3.4.0']
117+
self.client.user_agent_extensions = expected_user_agent_extensions
124118
self.client.request('GET', 'https://api.twilio.com/')
125-
request_header = self.client.http_client.last_request.headers['User-Agent']
126-
expected_user_agent = 'twilio-python/{} ({} {}) Python/{} {} {}'.format(
127-
__version__,
128-
platform.system(),
129-
platform.machine(),
130-
platform.python_version(),
131-
user_agent_extensions[0],
132-
user_agent_extensions[1]
133-
)
134-
self.assertEqual(request_header, expected_user_agent)
119+
user_agent_headers = self.client.http_client.last_request.headers['User-Agent']
120+
user_agent_extensions = user_agent_headers.split(" ")[-len(expected_user_agent_extensions):]
121+
self.assertEqual(user_agent_extensions, expected_user_agent_extensions)

0 commit comments

Comments
 (0)