Merge pull request #347 from twilio/voice-response-devx5022

Make url parameter optional

Author: dougblack

tests/unit/twiml/test_voice_response.py

@@ -120,7 +120,7 @@ class TestPlay(TwilioTest):
     def test_empty_play(self):
         """ should play hello monkey """
         r = VoiceResponse()
-        r.play('')
+        r.play()
 
         assert_equal(
             self.strip(r),
@@ -130,7 +130,7 @@ def test_empty_play(self):
     def test_play_hello(self):
         """ should play hello monkey """
         r = VoiceResponse()
-        r.play('http://hellomonkey.mp3')
+        r.play(url='http://hellomonkey.mp3')
 
         assert_equal(
             self.strip(r),
@@ -140,7 +140,7 @@ def test_play_hello(self):
     def test_play_hello_loop(self):
         """ should play hello monkey loop """
         r = VoiceResponse()
-        r.play('http://hellomonkey.mp3', loop=3)
+        r.play(url='http://hellomonkey.mp3', loop=3)
 
         assert_equal(
             self.strip(r),
@@ -150,7 +150,7 @@ def test_play_hello_loop(self):
     def test_play_digits(self):
         """ should play digits """
         r = VoiceResponse()
-        r.play('', digits='w123')
+        r.play(digits='w123')
 
         assert_equal(
             self.strip(r),
@@ -579,7 +579,7 @@ def test_nested_say_play_pause(self):
         """ a gather with a say, play, and pause """
         g = Gather()
         g.say('Hey')
-        g.play('hey.mp3')
+        g.play(url='hey.mp3')
         g.pause()
 
         r = VoiceResponse()

twilio/twiml/voice_response.py

@@ -164,7 +164,7 @@ def pause(self, length=None):
         return self.append(Pause(length=length))
 
     def play(self,
-             url,
+             url=None,
              loop=None,
              digits=None,
              **kwargs):
@@ -178,7 +178,7 @@ def play(self,
         :return: <Play> element
         """
         return self.append(Play(
-            url,
+            url=url,
             loop=loop,
             digits=digits,
             **kwargs
@@ -697,7 +697,7 @@ def say(self,
         ))
 
     def play(self,
-             url,
+             url=None,
              loop=None,
              digits=None,
              **kwargs):
@@ -711,7 +711,7 @@ def play(self,
         :return: <Play> element
         """
         return self.append(Play(
-            url,
+            url=url,
             loop=loop,
             digits=digits,
             **kwargs
@@ -738,12 +738,12 @@ class Play(TwiML):
     """
     <Play> element
     """
-    def __init__(self, url, **kwargs):
+    def __init__(self, url=None, **kwargs):
         """
         Create a new <Play> element
 
-        :param url: media URL
-        :param kwargs: additional attributes
+        :param url: optional media URL
+        :param kwargs: attributes
         """
         super(Play, self).__init__(**kwargs)
         self.value = url