From e0ae9c02579acd393043c5fa6018b19741741491 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 11:58:53 -0500 Subject: [PATCH 01/27] chore(ci): add contribution labeler --- .github/opened-pr-contribution-labeler.yml | 5 +++++ .github/opened-pr-labeler.yml | 5 ----- .github/workflows/on_pull_request_open.yml | 18 ++++++++++++++---- 3 files changed, 19 insertions(+), 9 deletions(-) create mode 100644 .github/opened-pr-contribution-labeler.yml delete mode 100644 .github/opened-pr-labeler.yml diff --git a/.github/opened-pr-contribution-labeler.yml b/.github/opened-pr-contribution-labeler.yml new file mode 100644 index 0000000000..8d1b4b8ae4 --- /dev/null +++ b/.github/opened-pr-contribution-labeler.yml @@ -0,0 +1,5 @@ +# https://github.com/actions/labeler + +# Add 'Contribution' label to any opened PR when author external to team +"Contribution": + - "**/*" diff --git a/.github/opened-pr-labeler.yml b/.github/opened-pr-labeler.yml deleted file mode 100644 index 3b77ee3001..0000000000 --- a/.github/opened-pr-labeler.yml +++ /dev/null @@ -1,5 +0,0 @@ -# https://github.com/actions/labeler - -# Add 'Status: Do Not Merge' label to any newly opened PR -"Status: Do Not Merge": - - "**/*" diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index b76c95762e..13fe334a17 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -8,10 +8,20 @@ jobs: pr-triage: runs-on: ubuntu-latest steps: - - name: Auto labeller + - name: Assign Author + uses: technote-space/assign-author@v1 + + - name: Check user for team affiliation + uses: tspascoal/get-user-teams-membership@v2 + id: teamAffiliation + with: + GITHUB_TOKEN: ${{ secrets.TOKEN }} + username: ${{ inputs.USER_NAME }} + team: "twilio-labs/design-systems-eng,twilio-labs/design-systems-pd" + + - name: Auto contribution labeller + if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} uses: actions/labeler@v4 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" - configuration-path: .github/opened-pr-labeler.yml - - name: Assign Author - uses: technote-space/assign-author@v1 + configuration-path: .github/opened-pr-contribution-labeler.yml From 801b1dd879f9c42aff13b6eaef56081fd3547d10 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:02:22 -0500 Subject: [PATCH 02/27] chore(ci): update env var --- .github/workflows/on_pull_request_open.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 13fe334a17..f3c74e8003 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -15,7 +15,7 @@ jobs: uses: tspascoal/get-user-teams-membership@v2 id: teamAffiliation with: - GITHUB_TOKEN: ${{ secrets.TOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} username: ${{ inputs.USER_NAME }} team: "twilio-labs/design-systems-eng,twilio-labs/design-systems-pd" From 21a87a4d8c73033c8eb1cf7c501b8223aee43c98 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:06:49 -0500 Subject: [PATCH 03/27] chore(ci): update triggers --- .github/workflows/on_pull_request_open.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index f3c74e8003..68e6d24d72 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -2,7 +2,7 @@ name: Opened Pull Request Labeler on: pull_request: - types: [opened] + types: [opened, reopened] jobs: pr-triage: From 5aae6cd5c84175b5e4ee5063810629b80222ed92 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:09:20 -0500 Subject: [PATCH 04/27] chore(ci): update username var --- .github/workflows/on_pull_request_open.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 68e6d24d72..8f1ce3aad0 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -16,7 +16,7 @@ jobs: id: teamAffiliation with: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - username: ${{ inputs.USER_NAME }} + username: ${{ github.actor }} team: "twilio-labs/design-systems-eng,twilio-labs/design-systems-pd" - name: Auto contribution labeller From a0f846e5f69892616c8fd6db6271b807a6738caf Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:17:20 -0500 Subject: [PATCH 05/27] chore(ci): update env --- .github/workflows/on_pull_request_open.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 8f1ce3aad0..7fc000adac 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -15,7 +15,7 @@ jobs: uses: tspascoal/get-user-teams-membership@v2 id: teamAffiliation with: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_TOKEN: ${{ secrets.PAT_GH_READ_ORG }} username: ${{ github.actor }} team: "twilio-labs/design-systems-eng,twilio-labs/design-systems-pd" From 4bbe2dcb1b622af8dda5616ff48b7415e0269d14 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:23:26 -0500 Subject: [PATCH 06/27] chore(ci): debug step --- .github/workflows/on_pull_request_open.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 7fc000adac..08b168c2bd 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -19,6 +19,9 @@ jobs: username: ${{ github.actor }} team: "twilio-labs/design-systems-eng,twilio-labs/design-systems-pd" + - name: Debug in group + run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" + - name: Auto contribution labeller if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} uses: actions/labeler@v4 From 759d6a88eb8b45e0c7dc70fb493a486c0380c5fa Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:26:03 -0500 Subject: [PATCH 07/27] chore(ci): update teams --- .github/workflows/on_pull_request_open.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 08b168c2bd..72ddad3df5 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -2,7 +2,7 @@ name: Opened Pull Request Labeler on: pull_request: - types: [opened, reopened] + types: [opened, synchronize] jobs: pr-triage: @@ -17,7 +17,7 @@ jobs: with: GITHUB_TOKEN: ${{ secrets.PAT_GH_READ_ORG }} username: ${{ github.actor }} - team: "twilio-labs/design-systems-eng,twilio-labs/design-systems-pd" + team: "design-systems-eng,design-systems-pd" - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" From c146b337c31e2e0730880fc657343e59bbd41b13 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:30:05 -0500 Subject: [PATCH 08/27] chore(ci): debug --- .github/workflows/on_pull_request_open.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 72ddad3df5..ff2bc58631 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -5,7 +5,7 @@ on: types: [opened, synchronize] jobs: - pr-triage: + pr-context-labeller: runs-on: ubuntu-latest steps: - name: Assign Author @@ -22,6 +22,16 @@ jobs: - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" + - name: Check user for team affiliation + uses: tspascoal/get-user-teams-membership@v2 + id: teamAffiliationList + with: + GITHUB_TOKEN: ${{ secrets.PAT_GH_READ_ORG }} + username: ${{ github.actor }} + + - name: Debug groups + run: echo "${{ steps.teamAffiliationList.outputs.teams }}" + - name: Auto contribution labeller if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} uses: actions/labeler@v4 From e7028ff91a2344fe90e82d37b94109f81b2c818d Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:35:50 -0500 Subject: [PATCH 09/27] chore(ci): wip --- .github/workflows/on_pull_request_open.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index ff2bc58631..02c2fe1ff6 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -15,9 +15,9 @@ jobs: uses: tspascoal/get-user-teams-membership@v2 id: teamAffiliation with: - GITHUB_TOKEN: ${{ secrets.PAT_GH_READ_ORG }} - username: ${{ github.actor }} - team: "design-systems-eng,design-systems-pd" + GITHUB_TOKEN: "${{ secrets.PAT_GH_READ_ORG }}" + username: "${{ github.actor }}" + team: "Design Systems PD,design-systems,Design Systems Eng,Design Systems Eng Leads" - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" @@ -26,8 +26,8 @@ jobs: uses: tspascoal/get-user-teams-membership@v2 id: teamAffiliationList with: - GITHUB_TOKEN: ${{ secrets.PAT_GH_READ_ORG }} - username: ${{ github.actor }} + GITHUB_TOKEN: "${{ secrets.PAT_GH_READ_ORG }}" + username: "${{ github.actor }}" - name: Debug groups run: echo "${{ steps.teamAffiliationList.outputs.teams }}" From 4acef7d7afec00f0bfe19edda5aeca21085bb34c Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:36:51 -0500 Subject: [PATCH 10/27] chore(ci): wip --- .github/workflows/on_pull_request_open.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 02c2fe1ff6..b9ed38dbb5 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -17,7 +17,9 @@ jobs: with: GITHUB_TOKEN: "${{ secrets.PAT_GH_READ_ORG }}" username: "${{ github.actor }}" - team: "Design Systems PD,design-systems,Design Systems Eng,Design Systems Eng Leads" + team: "Design Systems PD" + + # ,design-systems,Design Systems Eng,Design Systems Eng Leads - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" From d84104d0b0122f20c70e5c7006c9b799f30caf4a Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:38:47 -0500 Subject: [PATCH 11/27] chore(ci): wip --- .github/workflows/on_pull_request_open.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index b9ed38dbb5..bdb0e15792 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -8,6 +8,11 @@ jobs: pr-context-labeller: runs-on: ubuntu-latest steps: + - name: Checkout Repo + uses: actions/checkout@v4 + with: + fetch-depth: 0 + - name: Assign Author uses: technote-space/assign-author@v1 From 8c9e35b3cf32c44d8fbec32013c395c76143574c Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:42:41 -0500 Subject: [PATCH 12/27] chore(ci): wip --- .github/workflows/on_pull_request_open.yml | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index bdb0e15792..9fac4c9aee 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -13,6 +13,11 @@ jobs: with: fetch-depth: 0 + - name: Setup Node.js 20.5 + uses: actions/setup-node@v4 + with: + node-version: 20.5.x + - name: Assign Author uses: technote-space/assign-author@v1 @@ -22,6 +27,7 @@ jobs: with: GITHUB_TOKEN: "${{ secrets.PAT_GH_READ_ORG }}" username: "${{ github.actor }}" + # List of all teams for dsys team: "Design Systems PD" # ,design-systems,Design Systems Eng,Design Systems Eng Leads @@ -29,16 +35,6 @@ jobs: - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" - - name: Check user for team affiliation - uses: tspascoal/get-user-teams-membership@v2 - id: teamAffiliationList - with: - GITHUB_TOKEN: "${{ secrets.PAT_GH_READ_ORG }}" - username: "${{ github.actor }}" - - - name: Debug groups - run: echo "${{ steps.teamAffiliationList.outputs.teams }}" - - name: Auto contribution labeller if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} uses: actions/labeler@v4 From cd6c4cf78379e44c79886d80b326ba7513a5cc3f Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:46:19 -0500 Subject: [PATCH 13/27] chore(ci): wip --- .github/workflows/on_pull_request.yml | 2 +- .github/workflows/on_pull_request_open.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/on_pull_request.yml b/.github/workflows/on_pull_request.yml index 457fc1fc34..fea064fefe 100644 --- a/.github/workflows/on_pull_request.yml +++ b/.github/workflows/on_pull_request.yml @@ -450,7 +450,7 @@ jobs: - name: Checkout Repo uses: actions/checkout@v4 - - uses: actions/labeler@v4 + - uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" sync-labels: true diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 9fac4c9aee..2d36b472d8 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -37,7 +37,7 @@ jobs: - name: Auto contribution labeller if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} - uses: actions/labeler@v4 + uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" configuration-path: .github/opened-pr-contribution-labeler.yml From 795d062a8fcadb6a4b7c0b42e55ea00d00d18b39 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:52:32 -0500 Subject: [PATCH 14/27] chore(ci): update ver --- .github/labeler.yml | 41 +++++++++++++--------- .github/opened-pr-contribution-labeler.yml | 3 +- 2 files changed, 26 insertions(+), 18 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 7cc6631b04..1f818302a7 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -2,42 +2,49 @@ # Add 'repo' label to any root file changes "Area: Repo": - - "*" + - changed-files: + - any-glob-to-any-file: "*" "Area: Primitives": - - packages/paste-core/primitives/**/* + - changed-files: + - any-glob-to-any-file: packages/paste-core/primitives/**/* "Area: Layout": - - packages/paste-core/layout/**/* + - changed-files: + - any-glob-to-any-file: packages/paste-core/layout/**/* "Area: Components": - - packages/paste-core/components/**/* + - changed-files: + - any-glob-to-any-file: packages/paste-core/components/**/* "Area: Core bundle": - - packages/paste-core/core-bundle/**/* + - changed-files: + - any-glob-to-any-file: packages/paste-core/core-bundle/**/* "Area: Doc Site": - - packages/paste-website/**/* + - changed-files: + - any-glob-to-any-file: packages/paste-website/**/* "Area: Theme": - - packages/paste-theme/**/* + - changed-files: + - any-glob-to-any-file: packages/paste-theme/**/* "Area: Tokens": - - packages/paste-design-tokens/**/* + - changed-files: + - any-glob-to-any-file: packages/paste-design-tokens/**/* "Area: Storybook": - - .storybook/**/* + - changed-files: + - any-glob-to-any-file: .storybook/**/* "Area: Infrastructure": - - .eslint/**/* - - .github/**/* - - .jest/**/* - - .vscode/**/* - - tools/**/* + - changed-files: + - any-glob-to-any-file: [".github/**/*", ".jest/**/*", ".storybook/**/*", ".vscode/**/*", "tools/**/*"] "Type: Documentation": - - packages/paste-website/src/pages/**/* + - changed-files: + - any-glob-to-any-file: packages/paste-website/src/pages/**/* "Type: Tests": - - "**/__tests__/**/*" - - cypress/**/* + - changed-files: + - any-glob-to-any-file: ["**/__tests__/**/*", "cypress/**/*"] diff --git a/.github/opened-pr-contribution-labeler.yml b/.github/opened-pr-contribution-labeler.yml index 8d1b4b8ae4..608f1d43df 100644 --- a/.github/opened-pr-contribution-labeler.yml +++ b/.github/opened-pr-contribution-labeler.yml @@ -2,4 +2,5 @@ # Add 'Contribution' label to any opened PR when author external to team "Contribution": - - "**/*" + - changed-files: + - any-glob-to-any-file: "*" From 3373b794726d7fef0dbea9994a02afac90df010e Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:55:31 -0500 Subject: [PATCH 15/27] chore(ci): wip --- .github/workflows/on_pull_request_open.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 2d36b472d8..acd4d87250 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -10,13 +10,6 @@ jobs: steps: - name: Checkout Repo uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - name: Setup Node.js 20.5 - uses: actions/setup-node@v4 - with: - node-version: 20.5.x - name: Assign Author uses: technote-space/assign-author@v1 @@ -40,4 +33,5 @@ jobs: uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" + sync-labels: true configuration-path: .github/opened-pr-contribution-labeler.yml From f0f161f86eb354a5597f7fd8b8ffdca279415470 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:57:01 -0500 Subject: [PATCH 16/27] chore(ci): wip --- .github/workflows/on_pull_request.yml | 2 +- .github/workflows/on_pull_request_open.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/on_pull_request.yml b/.github/workflows/on_pull_request.yml index fea064fefe..58513a08a1 100644 --- a/.github/workflows/on_pull_request.yml +++ b/.github/workflows/on_pull_request.yml @@ -453,7 +453,7 @@ jobs: - uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" - sync-labels: true + sync-labels: false danger: name: Danger checks diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index acd4d87250..df618245d6 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -33,5 +33,5 @@ jobs: uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" - sync-labels: true + sync-labels: false configuration-path: .github/opened-pr-contribution-labeler.yml From 3bbf17b75a5c739f5773ee750801d24abaffa816 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:58:37 -0500 Subject: [PATCH 17/27] chore(ci): wip --- .github/opened-pr-contribution-labeler.yml | 4 ++++ .github/workflows/on_pull_request_open.yml | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/opened-pr-contribution-labeler.yml b/.github/opened-pr-contribution-labeler.yml index 608f1d43df..36824357f0 100644 --- a/.github/opened-pr-contribution-labeler.yml +++ b/.github/opened-pr-contribution-labeler.yml @@ -4,3 +4,7 @@ "Contribution": - changed-files: - any-glob-to-any-file: "*" + +"Status: Do Not Merge": + - changed-files: + - any-glob-to-any-file: "*" diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index df618245d6..b2cf7953a5 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -11,9 +11,6 @@ jobs: - name: Checkout Repo uses: actions/checkout@v4 - - name: Assign Author - uses: technote-space/assign-author@v1 - - name: Check user for team affiliation uses: tspascoal/get-user-teams-membership@v2 id: teamAffiliation @@ -35,3 +32,6 @@ jobs: repo-token: "${{ secrets.GITHUB_TOKEN }}" sync-labels: false configuration-path: .github/opened-pr-contribution-labeler.yml + + - name: Assign Author + uses: technote-space/assign-author@v1 From 365b0c529fde5cf71034a4eb9e92f40b2714ba9c Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 12:59:31 -0500 Subject: [PATCH 18/27] chore(ci): wip --- .github/workflows/on_pull_request.yml | 2 +- .github/workflows/on_pull_request_open.yml | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/on_pull_request.yml b/.github/workflows/on_pull_request.yml index 58513a08a1..fea064fefe 100644 --- a/.github/workflows/on_pull_request.yml +++ b/.github/workflows/on_pull_request.yml @@ -453,7 +453,7 @@ jobs: - uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" - sync-labels: false + sync-labels: true danger: name: Danger checks diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index b2cf7953a5..78954487ed 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -30,7 +30,6 @@ jobs: uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" - sync-labels: false configuration-path: .github/opened-pr-contribution-labeler.yml - name: Assign Author From b35a89026e1a95e6d517d3e5c9398d2e619d41ac Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 13:14:02 -0500 Subject: [PATCH 19/27] chore(ci): wip --- .github/workflows/on_pull_request_open.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 78954487ed..cc2e8c34e7 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -26,7 +26,7 @@ jobs: run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" - name: Auto contribution labeller - if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} + # if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" From 2948c44677ef08c326dfabd9454d33beb36a3157 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 13:16:46 -0500 Subject: [PATCH 20/27] chore(ci): wip --- .github/labeler.yml | 2 +- .github/opened-pr-contribution-labeler.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 1f818302a7..4b11970fbc 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -3,7 +3,7 @@ # Add 'repo' label to any root file changes "Area: Repo": - changed-files: - - any-glob-to-any-file: "*" + - any-glob-to-any-file: "*/**" "Area: Primitives": - changed-files: diff --git a/.github/opened-pr-contribution-labeler.yml b/.github/opened-pr-contribution-labeler.yml index 36824357f0..bdc6e26700 100644 --- a/.github/opened-pr-contribution-labeler.yml +++ b/.github/opened-pr-contribution-labeler.yml @@ -3,8 +3,8 @@ # Add 'Contribution' label to any opened PR when author external to team "Contribution": - changed-files: - - any-glob-to-any-file: "*" + - any-glob-to-any-file: "*/**" "Status: Do Not Merge": - changed-files: - - any-glob-to-any-file: "*" + - any-glob-to-any-file: "*/**" From a95b220fa53d4dc278b1054e75ef84531134033e Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 13:17:53 -0500 Subject: [PATCH 21/27] chore(ci): wip --- .github/workflows/on_pull_request_open.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index cc2e8c34e7..78954487ed 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -26,7 +26,7 @@ jobs: run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" - name: Auto contribution labeller - # if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} + if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} uses: actions/labeler@v5 with: repo-token: "${{ secrets.GITHUB_TOKEN }}" From 78a01ee106754b9758f7175e89ba5d51314434e6 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 13:18:54 -0500 Subject: [PATCH 22/27] chore(ci): final imp --- .github/opened-pr-contribution-labeler.yml | 4 ---- .github/workflows/on_pull_request_open.yml | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/opened-pr-contribution-labeler.yml b/.github/opened-pr-contribution-labeler.yml index bdc6e26700..46b1e143d0 100644 --- a/.github/opened-pr-contribution-labeler.yml +++ b/.github/opened-pr-contribution-labeler.yml @@ -4,7 +4,3 @@ "Contribution": - changed-files: - any-glob-to-any-file: "*/**" - -"Status: Do Not Merge": - - changed-files: - - any-glob-to-any-file: "*/**" diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 78954487ed..d47abec14a 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -18,9 +18,7 @@ jobs: GITHUB_TOKEN: "${{ secrets.PAT_GH_READ_ORG }}" username: "${{ github.actor }}" # List of all teams for dsys - team: "Design Systems PD" - - # ,design-systems,Design Systems Eng,Design Systems Eng Leads + team: "[Design Systems PD,design-systems,Design Systems Eng,Design Systems Eng Leads]" - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" From 2e4f44694a1f8da7d4b72ff93433ab3dfe2f11fd Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 13:20:02 -0500 Subject: [PATCH 23/27] chore(ci): final test --- .github/workflows/on_pull_request_open.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index d47abec14a..1f283381a7 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -18,7 +18,9 @@ jobs: GITHUB_TOKEN: "${{ secrets.PAT_GH_READ_ORG }}" username: "${{ github.actor }}" # List of all teams for dsys - team: "[Design Systems PD,design-systems,Design Systems Eng,Design Systems Eng Leads]" + team: "Design Systems PD" + + #[Design Systems PD,design-systems,Design Systems Eng,Design Systems Eng Leads] - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" From a8570584446cfbd9a699ac9df65320acb8311dcf Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 13:21:15 -0500 Subject: [PATCH 24/27] chore(ci): final impl --- .github/workflows/on_pull_request_open.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index 1f283381a7..d47abec14a 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -18,9 +18,7 @@ jobs: GITHUB_TOKEN: "${{ secrets.PAT_GH_READ_ORG }}" username: "${{ github.actor }}" # List of all teams for dsys - team: "Design Systems PD" - - #[Design Systems PD,design-systems,Design Systems Eng,Design Systems Eng Leads] + team: "[Design Systems PD,design-systems,Design Systems Eng,Design Systems Eng Leads]" - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" From f9d86082ee1c792de43562bd88ba6c8738378c53 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 13:22:02 -0500 Subject: [PATCH 25/27] chore(ci): change ton only fire on open --- .github/workflows/on_pull_request_open.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index d47abec14a..dbb0fcc918 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -2,7 +2,7 @@ name: Opened Pull Request Labeler on: pull_request: - types: [opened, synchronize] + types: [opened] jobs: pr-context-labeller: From 89791085f9e80864636f11e3c2ff2c0a60ca94fc Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Mon, 14 Oct 2024 15:16:38 -0500 Subject: [PATCH 26/27] chore(ci): spelling update --- .github/workflows/on_pull_request_open.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/on_pull_request_open.yml b/.github/workflows/on_pull_request_open.yml index dbb0fcc918..6c7c415904 100644 --- a/.github/workflows/on_pull_request_open.yml +++ b/.github/workflows/on_pull_request_open.yml @@ -5,7 +5,7 @@ on: types: [opened] jobs: - pr-context-labeller: + pr-context-labeler: runs-on: ubuntu-latest steps: - name: Checkout Repo @@ -23,7 +23,7 @@ jobs: - name: Debug in group run: echo "${{ github.actor }} is team member ${{ steps.teamAffiliation.outputs.isTeamMember }}" - - name: Auto contribution labeller + - name: Auto contribution labeler if: ${{ steps.teamAffiliation.outputs.isTeamMember == 'false' }} uses: actions/labeler@v5 with: From 321b087c7c503af8f0df4d2f2ec8dcad91fabef8 Mon Sep 17 00:00:00 2001 From: Kristian Antrobus Date: Tue, 15 Oct 2024 12:13:24 -0500 Subject: [PATCH 27/27] chore(deps): update ubuntu version --- .github/workflows/on_pull_request.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/on_pull_request.yml b/.github/workflows/on_pull_request.yml index fea064fefe..7dc9548a95 100644 --- a/.github/workflows/on_pull_request.yml +++ b/.github/workflows/on_pull_request.yml @@ -382,7 +382,8 @@ jobs: storybook_tests: name: Storybook test runner - runs-on: ubuntu-latest + # Causes playwrite issues in latest versions. Upgrading deps causes violations in the storybook tests. + runs-on: ubuntu-22.04 timeout-minutes: 20 needs: chromatic strategy: