From 60b39df2a4b8164e71d18ebb7af95502c7b396ac Mon Sep 17 00:00:00 2001 From: Shoaib Ahmed Date: Fri, 11 Oct 2024 19:55:15 +0530 Subject: [PATCH 1/3] fix(visual-picker): fix checkbox click --- .../components/visual-picker/src/VisualPickerCheckbox.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/paste-core/components/visual-picker/src/VisualPickerCheckbox.tsx b/packages/paste-core/components/visual-picker/src/VisualPickerCheckbox.tsx index c97420f1d0..cc162f5408 100644 --- a/packages/paste-core/components/visual-picker/src/VisualPickerCheckbox.tsx +++ b/packages/paste-core/components/visual-picker/src/VisualPickerCheckbox.tsx @@ -115,7 +115,7 @@ export const VisualPickerCheckbox = React.forwardRef {labelText} e.stopPropagation()} + onClick={(e) => e.preventDefault()} borderRadius="borderRadius20" element={`${element}_CONTROL`} disabled={disabled} From a98750fa531feb9a0fcc6a901c3e37b377cca587 Mon Sep 17 00:00:00 2001 From: Shoaib Ahmed Date: Fri, 11 Oct 2024 20:00:15 +0530 Subject: [PATCH 2/3] fix(visual-picker): add changeset --- .changeset/modern-starfishes-matter.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/modern-starfishes-matter.md diff --git a/.changeset/modern-starfishes-matter.md b/.changeset/modern-starfishes-matter.md new file mode 100644 index 0000000000..d7d619b9c3 --- /dev/null +++ b/.changeset/modern-starfishes-matter.md @@ -0,0 +1,6 @@ +--- +"@twilio-paste/visual-picker": patch +"@twilio-paste/core": patch +--- + +[Visual Picker]: Visual Picker Checkbox doesn't work in Firefox when checkbox is clicked on directly From 2f8b4148351964a8c1ad46ed808a1ca43dc8cc16 Mon Sep 17 00:00:00 2001 From: Shoaib Ahmed Date: Sat, 12 Oct 2024 07:44:31 +0530 Subject: [PATCH 3/3] Update modern-starfishes-matter.md --- .changeset/modern-starfishes-matter.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/modern-starfishes-matter.md b/.changeset/modern-starfishes-matter.md index d7d619b9c3..c9ae55b1af 100644 --- a/.changeset/modern-starfishes-matter.md +++ b/.changeset/modern-starfishes-matter.md @@ -3,4 +3,4 @@ "@twilio-paste/core": patch --- -[Visual Picker]: Visual Picker Checkbox doesn't work in Firefox when checkbox is clicked on directly +[Visual Picker]: Fix Visual Picker checkbox doesn't work in firefox when checkbox is clicked on directly