Controlled Switch component does not work properly

[LechK]

Hi. I have noticed, that switch can't be controlled. If we clicking switch, but not changing "on" state, switch still changes.
Easiest way to reproduce, to use it with Alert Dialog.

const Example = () => {
  const id = useUID()
  const [on, setOn] = React.useState(false)
  const [alert, setAlert] = React.useState(false)
  return (
    <SwitchContainer id={id} label="I am a controlled Switch">
      <Switch on={on} onClick={(evt) => setAlert(true)} />
    </SwitchContainer>
    <AlertDialog
        heading="Submit application"
        isOpen={alert}
        onConfirm={setOn(!on)}
        onConfirmLabel="Submit"
        onDismiss={setAlert(false)}
        onDismissLabel="Cancel"
      >
       Alert something
    </AlertDialog>
  )
}

Because of that, we can't use Switch in some situations.

[ghost]

Thanks for the discussion here @LechK. I looked at the implementation and this does look like a bug! Our component doesn't take into account the presence of an onClick callback to manage controlled state, it also doesn't provide a similar check for keyDown events. I'll share with the team and we'll work on a fix

[TheSisb]

Hi @LechK,

Small update that we're actively working on a fix to this component. Hoping to have it ready by next week at the latest.

[nkrantz]

Here's the PR if you'd like to follow along: #2753

[shleewhite]

@LechK The fix has merged and will be available in our next version of the package: #2779.

[LechK]

ThankYou! 2022-10-28, pn, 19:48 Lee White ***@***.***> rašė:

…

@LechK <https://github.com/LechK> The fix has merged and will be available in our next version of the package: #2779 <#2779>. — Reply to this email directly, view it on GitHub <#2705 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALFZ6Z5WOTY3H462NXLPEF3WFP7V3ANCNFSM6AAAAAAQYRQO4Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>