From 2082499b427dc03a588c355b01e13782d4b9a356 Mon Sep 17 00:00:00 2001
From: Kelley R <krobinson@twilio.com>
Date: Fri, 20 Sep 2024 09:51:25 -0400
Subject: [PATCH] Change RELYING_PARTY to DOMAIN_NAME to use build in function
 context

---
 passkeys-backend/.env.example                      | 5 -----
 passkeys-backend/functions/authentication/start.js | 4 ++--
 passkeys-backend/functions/registration/start.js   | 6 +++---
 passkeys-backend/tests/registration-start.test.js  | 4 ++--
 4 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/passkeys-backend/.env.example b/passkeys-backend/.env.example
index acbe3973..5d4139e9 100644
--- a/passkeys-backend/.env.example
+++ b/passkeys-backend/.env.example
@@ -3,11 +3,6 @@
 # required: true
 API_URL=
 
-# description: The domain of the relying party
-# format: url
-# required: true
-RELYING_PARTY=
-
 # description: The domain of the adroid identity provider
 # format: list(text)
 # required: false
diff --git a/passkeys-backend/functions/authentication/start.js b/passkeys-backend/functions/authentication/start.js
index 22778efe..7b1c2746 100644
--- a/passkeys-backend/functions/authentication/start.js
+++ b/passkeys-backend/functions/authentication/start.js
@@ -2,7 +2,7 @@ const axios = require('axios');
 
 // eslint-disable-next-line consistent-return
 exports.handler = async (context, _, callback) => {
-  const { RELYING_PARTY, API_URL } = context;
+  const { DOMAIN_NAME, API_URL } = context;
 
   const response = new Twilio.Response();
   response.appendHeader('Content-Type', 'application/json');
@@ -12,7 +12,7 @@ exports.handler = async (context, _, callback) => {
   const requestBody = {
     content: {
       // eslint-disable-next-line camelcase
-      rp_id: RELYING_PARTY,
+      rp_id: DOMAIN_NAME,
     },
   };
 
diff --git a/passkeys-backend/functions/registration/start.js b/passkeys-backend/functions/registration/start.js
index 1d946b7f..a67c7dd3 100644
--- a/passkeys-backend/functions/registration/start.js
+++ b/passkeys-backend/functions/registration/start.js
@@ -4,7 +4,7 @@ const assets = Runtime.getAssets();
 const { detectMissingParams } = require(assets['/services/helpers.js'].path);
 
 exports.handler = async (context, event, callback) => {
-  const { RELYING_PARTY, API_URL, ANDROID_APP_KEYS } = context;
+  const { DOMAIN_NAME, API_URL, ANDROID_APP_KEYS } = context;
 
   const response = new Twilio.Response();
   response.appendHeader('Content-Type', 'application/json');
@@ -31,10 +31,10 @@ exports.handler = async (context, event, callback) => {
     },
     content: {
       relying_party: {
-        id: RELYING_PARTY,
+        id: DOMAIN_NAME,
         name: 'PasskeySample',
         origins: [
-          `https://${RELYING_PARTY}`,
+          `https://${DOMAIN_NAME}`,
           ...(ANDROID_APP_KEYS?.split(',') ?? []),
         ],
       },
diff --git a/passkeys-backend/tests/registration-start.test.js b/passkeys-backend/tests/registration-start.test.js
index 634a8ad6..9c0e08f7 100644
--- a/passkeys-backend/tests/registration-start.test.js
+++ b/passkeys-backend/tests/registration-start.test.js
@@ -7,7 +7,7 @@ jest.mock('axios');
 
 const mockContext = {
   API_URL: 'https://api.com',
-  RELYING_PARTY: 'example.com',
+  DOMAIN_NAME: 'example.com',
   ANDROID_APP_KEYS: 'key1,key2,key3',
   getTwilioClient: () => ({
     username: 'mockUsername',
@@ -93,7 +93,7 @@ describe('registration/start', () => {
 
     const mockContextWithoutAndroidKeys = {
       API_URL: 'https://api.com',
-      RELYING_PARTY: 'example.com',
+      DOMAIN_NAME: 'example.com',
       getTwilioClient: () => ({
         username: 'mockUsername',
         password: 'mockPassword',