Delete and Destroy buttons visible in Deleted records view #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

BOHEUS opened this issue May 11, 2025 · 0 comments

Contributor

BOHEUS commented May 11, 2025

Scenario:

Log in
Go to People tab (or any other tab)
Delete record
Open side menu and click "See deleted records"

Actual: Both Delete and Destroy buttons are visible

Expected: Only Destroy button is visible

Note: Delete button disappears when 2 or more records are selected

github-project-automation bot added this to 🎯 Roadmap & Sprints

github-project-automation bot moved this to 🔖 Planned in 🎯 Roadmap & Sprints

AjayAdsule mentioned this issue

Deleted view disable delete btn #11990

Merged

bosiraphael pushed a commit that referenced this issue


          Deleted view disable delete btn (#11990)

efffac2

This PR updates the defaultRecordActionConfig for the
SingleRecordActionKeys.DELETE action. A condition
!isSoftDeleteFilterActive was added to the shouldBeRegistered function
to ensure the delete button is only visible when the deleted records
view is not selected.

This prevents the delete button from appearing when viewing deleted
records.

#11974  

![Screenshot 2025-05-12 at 9 41
30 PM](https://github.com/user-attachments/assets/ab7c1f61-d5ab-4315-9f39-50108d11438c)

![Screenshot 2025-05-12 at 9 42
11 PM](https://github.com/user-attachments/assets/82a9843b-4d5e-406c-8186-dce5b7b16bf3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment