fix(transformation): update crawler algorithm (#7)

* fix: fix replace-node loop

* fix: compare nodes in transformation

Author: gmenih

src/Transformation.ts

@@ -17,9 +17,14 @@ export abstract class Transformation<T = {}> {
 
   public forEach = (input: ts.Node): ts.VisitResult<ts.Node> => {
     const node = this.visit(input)
-    return node instanceof Array
-      ? node.map(_ => ts.visitEachChild(_, this.forEach, this.ctx))
-      : ts.visitEachChild(node, this.forEach, this.ctx)
+
+    if (node === input) {
+      return node instanceof Array
+        ? node.map(_ => ts.visitEachChild(_, this.forEach, this.ctx))
+        : ts.visitEachChild(node, this.forEach, this.ctx)
+    }
+
+    return node
   }
 
   public toNode(template: string): ts.Node {

test/replace-node.test.ts

@@ -42,4 +42,25 @@ describe('replace-node', () => {
     }).newContent
     assert.strictEqual(actual, expected)
   })
+
+  it('should not fall into a loop if replaceWith contains a subset of matchWith', () => {
+    const input = normalize(`
+      function doAction (params) {
+        console.log(params.inputValue)
+      }
+    `)
+    const expected = normalize(`
+      function doAction (params) {
+        console.log(params && params.inputValue)
+      }
+    `)
+    
+    const actual = transform({
+      transformationCtor: ReplaceNode,
+      content: input,
+      path: './src/file.ts',
+      params: {matchWith: 'params.inputValue', replaceWith: 'params && params.inputValue'}
+    }).newContent
+    assert.strictEqual(actual, expected)
+  })
 })