Skip to content

Uniform Termination Process for Store Implementations: Ensuring Consistent Removal of Binary and .info Files #1075

@DarioCalovic

Description

@DarioCalovic

Describe the bug
Issueing the termination process the filestore removes both the binary as well as the .info file. The gcc store only removes the binary file.

To Reproduce
The .info is being ignored explicit: https://github.com/tus/tusd/blob/main/pkg/gcsstore/gcsservice.go#L355

func (service *GCSService) FilterObjects(ctx context.Context, params GCSFilterParams) ([]string, error) {

# ...

  if strings.HasSuffix(objAttrs.Name, "info") {
    continue
  }

# ...


Expected behavior
The expected behavior is that all store implementations, including the GCS store, should uniformly handle the terminating process by removing both the binary files and their corresponding .info files. The termination process should be consistent across different store implementations to ensure a standardized and predictable behavior.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions