Skip to content

Wrong length of f_reg in evaluate_hessian #5

@lwitthaus

Description

@lwitthaus

I think the lengths of f_reg and self.reg_factor_f are not equal in

ln_f_reg_used = np.log(f_reg * self.reg_factor_f)

if a certain number of bins is ignored in the regularization.
I believe adding the line f_reg = f_reg[self._f_slice] between
if self._tau is not None:
if self.log_f_reg:

would solve the problem, just as it is done here:
if self._tau is not None:
f_reg = f_reg[self._f_slice]
if self.log_f_reg:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions