Control parameters of the application

[Jean-Romain]

Hi, thank you for this awesome software.

As far as I can tell the software as no tunable parameter. According to your paper there are a few parameters especially I think that in my case the sensitivity of the single child simplification is too aggressive. Would you be able to show me where are the most important parameters in the source code so I can first recompile with different hard coded values and then maybe make a PR to add tunable parameters in the UI if you wish.

Thank you

[LiangliangNan]

I don't quite understand which parameters you're interested in.

The following two parameters can control the LOD of the generated branches:

• AdTree/AdTree/skeleton.cpp

  Line 1468 in ddc1fc1

  static const int slices = 10;

• AdTree/AdTree/skeleton.cpp

  Line 1396 in ddc1fc1

  const double angle_interval = 2.0 * M_PI / slices;

  
  (the second one currently depends on the first one, but you can make it independent)

[Jean-Romain]

Thank you for your reply.

I don't quite understand which parameters you're interested in.

All actually. I found two important parameters myself:

An hard coded 1.0 here that seems to controls the Douglas-Peucker sensitivity

AdTree/AdTree/skeleton.cpp

Line 548 in ddc1fc1

if (distance >= 1.0 * r)

And an hard coded 0.019 here:

AdTree/AdTree/skeleton.cpp

Line 184 in ddc1fc1

keep_main_skeleton(&MST_, 0.019);

I modified the software to be able to control these parameters both in GUI and console mode. You can see my modifications here: Jean-Romain@2c8650b

There are probably other interesting parameters that I did not find yet. As far as I can tell slice only control the amount of nodes in the final object but does not control the algorithm itself.

Are you interested in a PR ?

[LiangliangNan]

Looks very nice! I will give it a try after some deadlines (end of Jan).

Some suggestions:
To not break the previous usage, those parameters should be made optional (with the default values).
Besides, the "usage" message in the main function should also include and explain these parameters.

[Jean-Romain]

The default parameters are your original parameters. The sliders are accompanied with a tooltip. However I'm not sure of the text I wrote. It is more a guess about the parameters. And I would like to provide access to more parameters if possible.