#9 - Made it possible to pass config to underlaying request object

Author: trygve-lie

lib/connection.js

@@ -22,10 +22,11 @@ var pckage          = require('../package.json'),
 
 
 
-var Connection = module.exports = function (keys) {
+var Connection = module.exports = function (keys, options) {
     var self = this;
 
     this.keys = keys;
+    this.options = options;
     this.request = undefined;
 
 
@@ -53,7 +54,7 @@ Connection.prototype.connect = function (endpoint, params, callback) {
         self = this,
         conf = { 
             headers: {
-                'User-Agent': 'twitter-stream-api/' + pckage.version + ', node.js',
+                'User-Agent': pckage.name + '/' + pckage.version + ', node.js',
                 'content-length': '0'
             },
             url: uri,
@@ -62,6 +63,17 @@ Connection.prototype.connect = function (endpoint, params, callback) {
         };
 
 
+    // Merge constructor options into request config Object
+
+    if (!util.isNullOrUndefined(self.options)) {
+        Object.keys(self.options).forEach(function (key) {
+            if (key === 'pool') {
+                conf[key] = self.options[key];
+            }
+        });
+    }
+
+
     // Input parameters is invalid
 
     if (util.isNullOrUndefined(params)) {
@@ -79,12 +91,12 @@ Connection.prototype.connect = function (endpoint, params, callback) {
 
 
     // Connection has stalled if data has not received after 90 seconds
-
+/*
     self.request.setTimeout(90000, function () {
         self.emit('connection error stall');
         self.destroy();
     });
-
+*/
 
     self.request.on('response', function (response) {
 

package.json

@@ -31,6 +31,7 @@
   "devDependencies": {
     "request-debug": "0.2.0",
     "jshint": "2.8.0",
+    "nock": "2.15.0",
     "tap": "2.2.0"
   }
 }

test/connection.js

@@ -0,0 +1,47 @@
+/* jshint node: true, strict: true */
+
+"use strict";
+
+var tap         = require('tap'),
+    nock        = require('nock'),
+    Connection  = require('../lib/connection.js');
+
+
+var keys    = {
+    consumer_key: "a",
+    consumer_secret: "b",
+    token: "c",
+    token_secret: "d"
+};
+
+
+
+tap.test('Connection() - constructor has "pool" attribute - "maxSockets" is set in internal request.js Object', function (t) {
+    var connection = new Connection(keys, {pool: {maxSockets: 100}});
+    var mockResponse = nock('https://sitestream.twitter.com')
+                        .get('/1.1/site.json?follow=1&follow=2')
+                        .reply(200, 'ok');
+
+    connection.connect('site', {
+        follow: ['1', '2']
+    }, function () {
+        t.equal(connection.request.pool.maxSockets, 100);
+        t.end();
+    });
+});
+
+
+
+tap.test('Connection() - constructor has no "pool" attribute - "maxSockets" is "undefined" ', function (t) {
+    var connection = new Connection(keys);
+    var mockResponse = nock('https://sitestream.twitter.com')
+                        .get('/1.1/site.json?follow=1&follow=2')
+                        .reply(200, 'ok');
+
+    connection.connect('site', {
+        follow: ['1', '2']
+    }, function () {
+        t.equal(connection.request.pool.maxSockets, undefined);
+        t.end();
+    });
+});