Skip to content

Commit f84885a

Browse files
authored
FAI-841: Python benchmarks failing since namespace migration (#82)
* Update benchmarks for new namespace * Update Maven version on GHA * Update GHA branch rules * Update PR benchmark action * Fix build Arrow converter action name * Remove file saving from PR benchmarks * Add skip fetching GH pages * Remove PR config
1 parent e690075 commit f84885a

File tree

2 files changed

+21
-23
lines changed

2 files changed

+21
-23
lines changed

.github/workflows/benchmarks-merge.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
name: TrustyAI Python benchmarks
1+
name: TrustyAI Python benchmarks (merge)
22

33
on:
44
push:
55
branches:
6-
- 'main'
7-
pull_request:
6+
- main
7+
88

99
permissions:
1010
contents: write
@@ -14,6 +14,7 @@ permissions:
1414

1515
jobs:
1616
benchmark:
17+
if: github.event.pull_request.merged == 'true'
1718
name: Run pytest-benchmark benchmark
1819
runs-on: ubuntu-latest
1920
steps:
@@ -28,11 +29,13 @@ jobs:
2829
check-latest: true
2930
- uses: stCarolas/setup-maven@v4
3031
with:
31-
maven-version: 3.5.4
32-
- name: Install dependencies
32+
maven-version: 3.8.1
33+
- name: Build explainability-core
34+
uses: ./.github/actions/build-core
35+
- name: Build arrow-converter
36+
uses: ./.github/actions/build-arrow
37+
- name: Install TrustyAI Python package
3338
run: |
34-
python -m pip install --upgrade pip
35-
pip install -r requirements.txt
3639
pip install -r requirements-dev.txt
3740
pip install .
3841
- name: Run benchmark

.github/workflows/benchmarks.yml

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
name: TrustyAI Python benchmarks
1+
name: TrustyAI Python benchmarks (PR)
22

33
on:
4-
push:
5-
branches:
6-
- '*'
7-
- '!main'
84
pull_request:
5+
branches:
6+
- main
97

108
permissions:
119
contents: write
@@ -29,27 +27,24 @@ jobs:
2927
check-latest: true
3028
- uses: stCarolas/setup-maven@v4
3129
with:
32-
maven-version: 3.5.4
33-
- name: Install dependencies
30+
maven-version: 3.8.1
31+
- name: Build explainability-core
32+
uses: ./.github/actions/build-core
33+
- name: Build arrow-converter
34+
uses: ./.github/actions/build-arrow
35+
- name: Install TrustyAI Python package
3436
run: |
35-
python -m pip install --upgrade pip
36-
pip install -r requirements.txt
3737
pip install -r requirements-dev.txt
3838
pip install .
3939
- name: Run benchmark
4040
run: |
4141
pytest tests/benchmarks/benchmark.py --benchmark-json tests/benchmarks/results.json
42-
- name: Store benchmark result
42+
- name: Benchmark result comment
4343
uses: benchmark-action/github-action-benchmark@v1
4444
with:
4545
name: TrustyAI continuous benchmarks
4646
tool: 'pytest'
47-
output-file-path: tests/benchmarks/results.json
48-
github-token: ${{ secrets.GITHUB_TOKEN }}
4947
auto-push: false
50-
alert-threshold: '200%'
51-
comment-on-alert: true
5248
comment-always: true
5349
fail-on-alert: false
54-
save-data-file: false
55-
alert-comment-cc-users: '@ruivieira'
50+
alert-comment-cc-users: '@ruivieira'

0 commit comments

Comments
 (0)