Build error while installing with cargo

[0lezsha]

cargo install --locked trunk

causes error:

error: failed to run custom build command for openssl-sys v0.9.103

OpenSSL libdir at ["C:\\Users\\bestuser\\scoop\\apps\\openssl\\current\\lib"] does not contain the required files to either statically or dynamically link OpenSSL

Full error output

(Windows 10 22H2 Home Edition)

What should I do? There was no problem with this a couple of months ago, what happened?

[ctron]

What happened is that ring (which was originally the default) chose to add some native code too (by default). However, that build was also problematic. So the default was switched to openssl.

I'd recommend installing a pre-compiled binary. Or follow what the CI is doing:

trunk/.github/workflows/release.yaml

Lines 83 to 84 in 4c9d85f

	echo "VCPKG_ROOT=$env:VCPKG_INSTALLATION_ROOT" | Out-File -FilePath $env:GITHUB_ENV -Append
	vcpkg install openssl:x64-windows-static-md

An alternative would be to find a way that we can re-enable ring as a default without any native code. Might be a bit of effort, but worth it. PRs welcome 😉

[s-mayrh]

I am on the windows-gnu toolchain (can't use msvc). trunk depends on openssl-sys now, so i installed openssl-devel into my MSYS2 install to get around the errors about missing headers and then needed to set OPENSSL_DIR environment variable to make the build process find them.

Unfortunately linking now fails for openssl-sys with basic libc functions like dlopen, ioctl or __errno. Could be just another missing env variable to point into MSYS2 somewhere, but it's too much effort to fix this at the moment. Please test the windows-gnu toolchain in your CI as well, thanks!

EDIT: I will try to find a solution later this week and share instructions for windows-gnu toolchain users here

[ctron]

yes, you need msvc. not sure about other toolchains.

Please test the windows-gnu toolchain in your CI as well, thanks!

If you find that useful, then a PR would be wonderful.

[s-mayrh]

I tried cargo install -F rustls trunk to get around this by switching on the rustls feature but it still tries to build openssl-sys and fails. Also rustls draws in aws-lc-sys which fails building right after because there are build system issues on the windows-gnu toolchain as well, see aws/aws-lc-rs#599 (comment)

When I tried building with -F rustls feature last week I haven't seen openssl being used at all, but it's possible I didn't see it because the build order could have changed after I cleared my local cargo registry/cache.

I would certainly help to bring a solution forward, but I don't know how to proceed at the moment. As a workaround I might try the binary release for the time being.

[ctron]

Yes, it's unfortunate that rustls switched to some native build by default. That makes things a lot more difficult. IIRC there's feature flag for that too (with rustls). Someone just has to do it.

[stefnotch]

#923

Here we go, I made a PR :)