Support private plugin repositories

[gewenyu99]

Originally posted on Canny by Tyler Jang:

Support private repositories through a GITHUB_TOKEN, gh client, git credential manager, or built-in Trunk auth flow.

Private GitHub plugin repositories are not currently supported: https://docs.trunk.io/check/advanced-setup/plugins#plugins-scope

[sheldonhull]

I got notified of this option from @TylerJang27 which I appreciate being in beta.
I'll do my best to give it a try and report back progress 🙇🏻

[sheldonhull]

Yes. So is that managed bash cross platform. I know of the go package that has a shell that's cross platform but limited tooling in it like mkdir and awk aren't accessible.

Any details on docs on this managed bash so I can write some scripts that work on windows and Linux/mac?

[TylerJang27]

Sorry, I misspoke slightly. On Linux/Mac we'll inherit from your PATH and use the bash we find there (and whatever commands you call). On Windows we install from git-bash and also inherit your PATH.

You can get some additional debug info about what we run using trunk actions history <action-id> and looking at the YAML files. You can also set actions.output_level: verbose for some info as things execute

[sheldonhull]

@TylerJang27 so I setup an internal (org) repo, and confirmed it had a release with a new version.
Then running trunk upgrade it checked for updates, but did not increment the version to the new patch version.

This is github now since the toolchain is limited to supporting this for automatic updates.

I noticed the behavior also ended up replacing the beta flag version you mentioned, so I reran with trunk upgrade plugins and same behavior, no version update found.

[sheldonhull]

correction... wow it took a while to respond, probably something on my network. I did upgrade to next patch.

Querying ReleaseVersionService failed with message Unable to find latest release version [DAEMON]
[02-24 16:05:21] [plugin.cc:296] Got HTTP 404 curling plugin https://github.com/{ORG}/trunk-configs/archive/v0.3.19.zip, using git fallback [DAEMON]

I also noted this, which not clear on why this would come in debug logs, since I don't have it executing 1password for example, though I have the cli installed in my system.

[02-24 16:05:26] [download_tool.hh:32] Failed to create download for tool  with error '1password-cli' has no matching download for current os/cpu @ version:2.19.0 [DAEMON]
	[02-24 16:05:26] [download_tool.hh:32] Failed to create download for tool  with error 'dotnet' has no matching download for current os/cpu @ version:7.0.400 [DAEMON]
	[02-24 16:05:26] [trigger_set.hh:53] Failed to add regex: invalid perl operator: (?! [DAEMON]

[TylerJang27]

@sheldonhull This has now been released in 1.22.11!

[sheldonhull]

The docs saw this is still not supported, the link is dead, and I'm running into some issues right now that might be entirely just me. Can I get a confirmation that this is still supported?