Skip to content

Commit 7355c16

Browse files
authored
Technical/Update gem development dependencies (#34)
* Updated default test environment to Ruby 3.1 * Updated gem development dependencies * Changed faker to ffaker dependency * Updated rubocop/codeclimate/simplecov/circleci configs * Updated gem version, changelog
1 parent 7472da6 commit 7355c16

17 files changed

+91
-30
lines changed

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,12 @@ workflows:
120120
- linters-ruby:
121121
matrix:
122122
parameters:
123-
ruby-version: ["3.0"]
123+
ruby-version: ["3.1"]
124124
- tests-ruby:
125125
matrix:
126126
parameters:
127-
ruby-version: ["3.0"]
127+
ruby-version: ["3.1"]
128128
- compatibility-ruby:
129129
matrix:
130130
parameters:
131-
ruby-version: ["2.5", "2.6", "2.7"]
131+
ruby-version: ["2.5", "2.6", "2.7", "3.0"]

.circleci/gemspec_compatible

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
lib = File.expand_path('lib', __dir__)
3+
lib = ::File.expand_path('lib', __dir__)
44
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
55
require 'truemail/client/version'
66

@@ -28,10 +28,10 @@ Gem::Specification.new do |spec|
2828

2929
spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
3030
spec.bindir = 'exe'
31-
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
31+
spec.executables = spec.files.grep(%r{^exe/}) { |f| ::File.basename(f) }
3232
spec.require_paths = ['lib']
3333

34-
spec.add_development_dependency 'faker', '~> 2.19'
34+
spec.add_development_dependency 'ffaker', '~> 2.20'
3535
spec.add_development_dependency 'json_matchers', '~> 0.11.1'
3636
spec.add_development_dependency 'pry-byebug', '~> 3.9'
3737
spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'

.codeclimate.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ checks:
77
plugins:
88
rubocop:
99
enabled: true
10-
channel: rubocop-1-21
10+
channel: rubocop-1-25
1111

1212
reek:
1313
enabled: true

.rubocop.yml

Lines changed: 52 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ Naming/RescuedExceptionsVariableName:
3535
Naming/InclusiveLanguage:
3636
Enabled: false
3737

38+
Naming/BlockForwarding:
39+
Enabled: true
40+
3841
Style/Documentation:
3942
Enabled: false
4043

@@ -150,6 +153,27 @@ Style/QuotedSymbols:
150153
Style/RedundantSelfAssignmentBranch:
151154
Enabled: true
152155

156+
Style/FileRead:
157+
Enabled: true
158+
159+
Style/FileWrite:
160+
Enabled: true
161+
162+
Style/MapToHash:
163+
Enabled: true
164+
165+
Style/NumberedParameters:
166+
Enabled: true
167+
168+
Style/NumberedParametersLimit:
169+
Enabled: true
170+
171+
Style/OpenStructUse:
172+
Enabled: true
173+
174+
Style/SelectByRegexp:
175+
Enabled: true
176+
153177
Layout/LineLength:
154178
Max: 140
155179

@@ -268,6 +292,21 @@ Lint/AmbiguousRange:
268292
Lint/IncompatibleIoSelectWithFiberScheduler:
269293
Enabled: true
270294

295+
Lint/RequireRelativeSelfPath:
296+
Enabled: true
297+
298+
Lint/UselessRuby2Keywords:
299+
Enabled: true
300+
301+
Gemspec/DateAssignment:
302+
Enabled: true
303+
304+
Gemspec/RequireMFA:
305+
Enabled: false
306+
307+
Security/IoMethods:
308+
Enabled: true
309+
271310
Performance/AncestorsInclude:
272311
Enabled: true
273312

@@ -316,7 +355,10 @@ Performance/RedundantSplitRegexpArgument:
316355
Performance/Sum:
317356
Enabled: true
318357

319-
Gemspec/DateAssignment:
358+
Performance/ConcurrentMonotonicTime:
359+
Enabled: true
360+
361+
Performance/StringIdentifierArgument:
320362
Enabled: true
321363

322364
RSpec/ExampleLength:
@@ -354,3 +396,12 @@ RSpec/IdenticalEqualityAssertion:
354396

355397
RSpec/Rails/AvoidSetupHook:
356398
Enabled: true
399+
400+
RSpec/ExcessiveDocstringSpacing:
401+
Enabled: true
402+
403+
RSpec/SubjectDeclaration:
404+
Enabled: true
405+
406+
RSpec/FactoryBot/SyntaxMethods:
407+
Enabled: true

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ruby-3.0.0
1+
ruby-3.1.0

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,16 @@
22

33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
44

5+
## [0.4.0] - 2022-01-26
6+
7+
### Changed
8+
9+
- Updated default test environment to Ruby 3.1
10+
- Updated gem development dependencies
11+
- Changed faker to ffaker dependency
12+
- Updated rubocop/codeclimate/simplecov/circleci configs
13+
- Updated gem version
14+
515
## [0.3.4] - 2021-09-16
616

717
### Changed

bin/console

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ require 'truemail/client'
1212
# Pry.start
1313

1414
require 'irb'
15-
IRB.start(__FILE__)
15+
::IRB.start(__FILE__)

lib/truemail/client/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
module Truemail
44
module Client
5-
VERSION = '0.3.4'
5+
VERSION = '0.4.0'
66
end
77
end
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# frozen_string_literal: true
22

3-
require 'faker'
3+
require 'ffaker'

spec/support/config/simplecov.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
if ::RUBY_VERSION[/\A3\.0.+\z/]
3+
if ::RUBY_VERSION[/\A3\.1.+\z/]
44
require 'simplecov'
55

66
SimpleCov.minimum_coverage(100)

spec/support/helpers/configuration_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def create_token
1717

1818
def configure_client(**configuration_settings)
1919
Truemail::Client.reset_configuration!
20-
configuration_settings[:host] = Faker::Internet.domain_name unless configuration_settings[:host]
20+
configuration_settings[:host] = FFaker::Internet.domain_name unless configuration_settings[:host]
2121
configuration_settings[:token] = create_token unless configuration_settings[:token]
2222
Truemail::Client.configure(&configuration_block(**configuration_settings))
2323
end

spec/support/helpers/configuration_helper_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
end
3939

4040
context 'with custom params' do
41-
let(:host) { Faker::Internet.domain_name }
41+
let(:host) { FFaker::Internet.domain_name }
4242
let(:token) { create_token }
4343
let(:params) { { host: host, token: token } }
4444

spec/support/helpers/request_helper_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
RSpec.describe RequestHelper, type: :helper do
44
describe '#have_sent_request_with' do
55
let(:secure_connection) { true }
6-
let(:host) { Faker::Internet.domain_name }
7-
let(:port) { rand(80..8080) }
6+
let(:host) { FFaker::Internet.domain_name }
7+
let(:port) { ::Random.rand(80..8080) }
88
let(:token) { create_token }
99
let(:method) { :get }
1010
let(:endpoint) { '/some_endpoint' }
11-
let(:request_params) { { email: Faker::Internet.email } }
11+
let(:request_params) { { email: FFaker::Internet.email } }
1212
let(:accept) { 'accept_header' }
1313
let(:content_type) { 'content_type_header' }
1414
let(:user_agent) { 'user_agent_header' }

spec/truemail/client/configuration_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
RSpec.describe Truemail::Client::Configuration do
44
subject(:configuration_instance) { described_class.new }
55

6-
let(:host) { Faker::Internet.domain_name }
6+
let(:host) { FFaker::Internet.domain_name }
77
let(:token) { create_token }
88

99
describe 'defined constants' do

spec/truemail/client/http_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
context 'when validation endpoint' do
2929
let(:endpoint) { Truemail::Client::Http::VALIDATION_ENDPOINT }
30-
let(:request_params) { { email: Faker::Internet.email } }
30+
let(:request_params) { { email: FFaker::Internet.email } }
3131
let(:request_settings) do
3232
{
3333
method: :get,

spec/truemail/client_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
end
88

99
describe 'global configuration methods' do
10-
let(:host) { Faker::Internet.domain_name }
10+
let(:host) { FFaker::Internet.domain_name }
1111
let(:token) { create_token }
1212
let(:config_block) { configuration_block(host: host, token: token) }
1313

@@ -70,7 +70,7 @@
7070
specify { expect(configuration).to be_instance_of(Truemail::Client::Configuration) }
7171

7272
it 'accepts to rewrite current configuration settings' do
73-
secure_connection, new_host, port, new_token = true, Faker::Internet.domain_name, 8080, create_token
73+
secure_connection, new_host, port, new_token = true, FFaker::Internet.domain_name, 8080, create_token
7474

7575
expect do
7676
configuration.tap(&configuration_block(
@@ -113,7 +113,7 @@
113113
describe '.validate' do
114114
subject(:validate) { described_class.validate(email) }
115115

116-
let(:email) { Faker::Internet.email }
116+
let(:email) { FFaker::Internet.email }
117117
let(:http_instance) { instance_double('Http') }
118118

119119
context 'when global configuration was set' do

truemail-client.gemspec

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
lib = File.expand_path('lib', __dir__)
3+
lib = ::File.expand_path('lib', __dir__)
44
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
55
require 'truemail/client/version'
66

@@ -28,21 +28,21 @@ Gem::Specification.new do |spec|
2828

2929
spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
3030
spec.bindir = 'exe'
31-
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
31+
spec.executables = spec.files.grep(%r{^exe/}) { |f| ::File.basename(f) }
3232
spec.require_paths = ['lib']
3333

3434
spec.add_development_dependency 'bundler-audit', '~> 0.9.0.1'
35-
spec.add_development_dependency 'faker', '~> 2.19'
3635
spec.add_development_dependency 'fasterer', '~> 0.9.0'
36+
spec.add_development_dependency 'ffaker', '~> 2.20'
3737
spec.add_development_dependency 'json_matchers', '~> 0.11.1'
3838
spec.add_development_dependency 'overcommit', '~> 0.58.0'
3939
spec.add_development_dependency 'pry-byebug', '~> 3.9'
4040
spec.add_development_dependency 'rake', '~> 13.0', '>= 13.0.6'
41-
spec.add_development_dependency 'reek', '~> 6.0', '>= 6.0.6'
41+
spec.add_development_dependency 'reek', '~> 6.1'
4242
spec.add_development_dependency 'rspec', '~> 3.10'
43-
spec.add_development_dependency 'rubocop', '~> 1.21'
44-
spec.add_development_dependency 'rubocop-performance', '~> 1.11', '>= 1.11.5'
45-
spec.add_development_dependency 'rubocop-rspec', '~> 2.4'
43+
spec.add_development_dependency 'rubocop', '~> 1.25'
44+
spec.add_development_dependency 'rubocop-performance', '~> 1.13', '>= 1.13.2'
45+
spec.add_development_dependency 'rubocop-rspec', '~> 2.8'
4646
spec.add_development_dependency 'simplecov', '~> 0.17.1'
4747
spec.add_development_dependency 'webmock', '~> 3.14'
4848
end

0 commit comments

Comments
 (0)