-
Notifications
You must be signed in to change notification settings - Fork 34
Add custom http handler and auth provider interface #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
02887a3
to
25d9b99
Compare
WineChord
reviewed
Apr 20, 2025
client/options.go
Outdated
@@ -17,6 +18,11 @@ import ( | |||
// Option is a functional option type for configuring the A2AClient. | |||
type Option func(*A2AClient) | |||
|
|||
// HttpReqHandler is a custom HTTP request handler for a2a client. | |||
type HttpReqHandler interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Http => HTTP
client/options.go
Outdated
@@ -95,3 +101,10 @@ func WithAuthProvider(provider auth.ClientProvider) Option { | |||
c.httpClient = provider.ConfigureClient(c.httpClient) | |||
} | |||
} | |||
|
|||
// WithHttpReqHandler sets a custom HTTP request handler for the A2AClient. | |||
func WithHttpReqHandler(handler HttpReqHandler) Option { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Http => HTTP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
FillRequestKey
to inject auth token for custom request handler.