Merge pull request #8 from giwa/always-patch-description

Author: giwa

lib/embulk/output/bigquery.rb

@@ -399,10 +399,7 @@ def self.transaction(config, schema, task_count, &control)
             end
           end
 
-          if task['mode'] == 'append' || task['mode'] == 'append_direct'
-            # update only column.description based on column_options
-            bigquery.patch_table
-          end
+          bigquery.patch_table
 
         ensure
           begin

test/test_transaction.rb

@@ -91,6 +91,7 @@ def test_delete_in_advance
             mock(obj).get_dataset(config['dataset'])
             mock(obj).delete_table_or_partition(config['table'])
             mock(obj).create_table_if_not_exists(config['table'])
+            mock(obj).patch_table
           end
           Bigquery.transaction(config, schema, processor_count, &control)
         end
@@ -102,6 +103,7 @@ def test_delete_in_advance_with_partitioning
             mock(obj).get_dataset(config['dataset'])
             mock(obj).delete_table_or_partition(config['table'])
             mock(obj).create_table_if_not_exists(config['table'])
+            mock(obj).patch_table
           end
           Bigquery.transaction(config, schema, processor_count, &control)
         end
@@ -117,6 +119,7 @@ def test_replace
             mock(obj).create_table_if_not_exists(config['table'])
             mock(obj).copy(config['temp_table'], config['table'], write_disposition: 'WRITE_TRUNCATE')
             mock(obj).delete_table(config['temp_table'])
+            mock(obj).patch_table
           end
           Bigquery.transaction(config, schema, processor_count, &control)
         end
@@ -130,6 +133,7 @@ def test_replace_with_partitioning
             mock(obj).create_table_if_not_exists(config['table'])
             mock(obj).copy(config['temp_table'], config['table'], write_disposition: 'WRITE_TRUNCATE')
             mock(obj).delete_table(config['temp_table'])
+            mock(obj).patch_table
           end
           Bigquery.transaction(config, schema, processor_count, &control)
         end
@@ -151,6 +155,7 @@ def test_replace_backup
 
             mock(obj).copy(config['temp_table'], config['table'], write_disposition: 'WRITE_TRUNCATE')
             mock(obj).delete_table(config['temp_table'])
+            mock(obj).patch_table
           end
           Bigquery.transaction(config, schema, processor_count, &control)
         end
@@ -170,6 +175,7 @@ def test_replace_backup_auto_create_dataset
 
             mock(obj).copy(config['temp_table'], config['table'], write_disposition: 'WRITE_TRUNCATE')
             mock(obj).delete_table(config['temp_table'])
+            mock(obj).patch_table
           end
           Bigquery.transaction(config, schema, processor_count, &control)
         end
@@ -189,6 +195,7 @@ def test_replace_backup_with_partitioning
 
             mock(obj).copy(config['temp_table'], config['table'], write_disposition: 'WRITE_TRUNCATE')
             mock(obj).delete_table(config['temp_table'])
+            mock(obj).patch_table
           end
           Bigquery.transaction(config, schema, processor_count, &control)
         end