From 0cc9d2e7d5bc800bb6c4fc6714090e89729472d7 Mon Sep 17 00:00:00 2001 From: Misha Chornyi Date: Thu, 17 Oct 2024 19:17:01 -0700 Subject: [PATCH 1/3] Update build.py configuration --- build.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/build.py b/build.py index 14301f843d..a84a888ef3 100755 --- a/build.py +++ b/build.py @@ -667,6 +667,16 @@ def onnxruntime_cmake_args(images, library_paths): else TRITON_VERSION_MAP[FLAGS.version][2], ) ] + # If variable is set, ONNX Runtime package will be downloaded from the specified URL + if os.getenv("TRITON_ONNXRUNTIME_PACKAGE_URL"): + cargs.append( + cmake_backend_arg( + "onnxruntime", + "TRITON_ONNXRUNTIME_PACKAGE_URL", + None, + os.getenv("TRITON_ONNXRUNTIME_PACKAGE_URL"), + ) + ) # TRITON_ENABLE_GPU is already set for all backends in backend_cmake_args() # TODO: TPRD-334 TensorRT extension is not currently supported by our manylinux build From fdae42aa531724dceb161f69fe2396698703e16a Mon Sep 17 00:00:00 2001 From: Misha Chornyi Date: Thu, 17 Oct 2024 21:13:01 -0700 Subject: [PATCH 2/3] Disable local cache for windows. --- build.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build.py b/build.py index a84a888ef3..d9fd8c3e53 100755 --- a/build.py +++ b/build.py @@ -1689,7 +1689,9 @@ def create_docker_build_script(script_name, container_install_dir, container_ci_ if FLAGS.container_memory: baseargs += ["--memory", FLAGS.container_memory] - baseargs += ["--cache-from={}".format(k) for k in cachefrommap] + if target_platform() != "windows": + baseargs += ["--cache-from={}".format(k) for k in cachefrommap] + baseargs += ["."] docker_script.cwd(THIS_SCRIPT_DIR) From 9ea80d64b48b9e6d9fc8de89cd7d7c07e4f59e39 Mon Sep 17 00:00:00 2001 From: Misha Chornyi Date: Mon, 28 Oct 2024 13:40:32 -0700 Subject: [PATCH 3/3] Remove dependency on environment variable --- build.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/build.py b/build.py index d9fd8c3e53..845dfd00f0 100755 --- a/build.py +++ b/build.py @@ -667,16 +667,6 @@ def onnxruntime_cmake_args(images, library_paths): else TRITON_VERSION_MAP[FLAGS.version][2], ) ] - # If variable is set, ONNX Runtime package will be downloaded from the specified URL - if os.getenv("TRITON_ONNXRUNTIME_PACKAGE_URL"): - cargs.append( - cmake_backend_arg( - "onnxruntime", - "TRITON_ONNXRUNTIME_PACKAGE_URL", - None, - os.getenv("TRITON_ONNXRUNTIME_PACKAGE_URL"), - ) - ) # TRITON_ENABLE_GPU is already set for all backends in backend_cmake_args() # TODO: TPRD-334 TensorRT extension is not currently supported by our manylinux build