Move method to GlueInputConverter

Author: ebyhr

plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/v1/GlueHiveMetastore.java

@@ -155,10 +155,10 @@
 import static io.trino.plugin.hive.metastore.MetastoreUtil.verifyCanDropColumn;
 import static io.trino.plugin.hive.metastore.glue.v1.AwsSdkUtil.getPaginatedResults;
 import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueInputConverter.convertFunction;
+import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueInputConverter.convertGlueTableToTableInput;
 import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueInputConverter.convertPartition;
 import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueToTrinoConverter.getTableParameters;
 import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueToTrinoConverter.getTableType;
-import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueToTrinoConverter.getTableTypeNullable;
 import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueToTrinoConverter.mappedCopy;
 import static io.trino.plugin.hive.util.HiveUtil.escapeSchemaName;
 import static io.trino.spi.StandardErrorCode.ALREADY_EXISTS;
@@ -510,7 +510,7 @@ public void renameTable(String databaseName, String tableName, String newDatabas
             GetTableRequest getTableRequest = new GetTableRequest().withDatabaseName(databaseName)
                     .withName(tableName);
             GetTableResult glueTable = glueClient.getTable(getTableRequest);
-            TableInput tableInput = convertGlueTableToTableInput(glueTable.getTable(), newTableName);
+            TableInput tableInput = convertGlueTableToTableInput(glueTable.getTable()).withName(newTableName);
             CreateTableRequest createTableRequest = new CreateTableRequest()
                     .withDatabaseName(newDatabaseName)
                     .withTableInput(tableInput);
@@ -533,24 +533,6 @@ public void renameTable(String databaseName, String tableName, String newDatabas
         }
     }
 
-    private static TableInput convertGlueTableToTableInput(com.amazonaws.services.glue.model.Table glueTable, String newTableName)
-    {
-        return new TableInput()
-                .withName(newTableName)
-                .withDescription(glueTable.getDescription())
-                .withOwner(glueTable.getOwner())
-                .withLastAccessTime(glueTable.getLastAccessTime())
-                .withLastAnalyzedTime(glueTable.getLastAnalyzedTime())
-                .withRetention(glueTable.getRetention())
-                .withStorageDescriptor(glueTable.getStorageDescriptor())
-                .withPartitionKeys(glueTable.getPartitionKeys())
-                .withViewOriginalText(glueTable.getViewOriginalText())
-                .withViewExpandedText(glueTable.getViewExpandedText())
-                .withTableType(getTableTypeNullable(glueTable))
-                .withTargetTable(glueTable.getTargetTable())
-                .withParameters(getTableParameters(glueTable));
-    }
-
     @Override
     public void commentTable(String databaseName, String tableName, Optional<String> comment)
     {

plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/v1/converter/GlueInputConverter.java

@@ -48,6 +48,8 @@
 import static io.trino.plugin.hive.metastore.MetastoreUtil.metastoreFunctionName;
 import static io.trino.plugin.hive.metastore.MetastoreUtil.toResourceUris;
 import static io.trino.plugin.hive.metastore.MetastoreUtil.updateStatisticsParameters;
+import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueToTrinoConverter.getTableParameters;
+import static io.trino.plugin.hive.metastore.glue.v1.converter.GlueToTrinoConverter.getTableTypeNullable;
 
 public final class GlueInputConverter
 {
@@ -89,6 +91,24 @@ public static TableInput convertTable(Table table)
         return input;
     }
 
+    public static TableInput convertGlueTableToTableInput(com.amazonaws.services.glue.model.Table glueTable)
+    {
+        return new TableInput()
+                .withName(glueTable.getName())
+                .withDescription(glueTable.getDescription())
+                .withOwner(glueTable.getOwner())
+                .withLastAccessTime(glueTable.getLastAccessTime())
+                .withLastAnalyzedTime(glueTable.getLastAnalyzedTime())
+                .withRetention(glueTable.getRetention())
+                .withStorageDescriptor(glueTable.getStorageDescriptor())
+                .withPartitionKeys(glueTable.getPartitionKeys())
+                .withViewOriginalText(glueTable.getViewOriginalText())
+                .withViewExpandedText(glueTable.getViewExpandedText())
+                .withTableType(getTableTypeNullable(glueTable))
+                .withTargetTable(glueTable.getTargetTable())
+                .withParameters(getTableParameters(glueTable));
+    }
+
     public static PartitionInput convertPartition(PartitionWithStatistics partitionWithStatistics)
     {
         PartitionInput input = convertPartition(partitionWithStatistics.getPartition());