Skip to content

Commit f2a515d

Browse files
committed
Log emulated access key instead of secret key
Unsure if this was instead for the initial development phases but we shouldn't be logging this now
1 parent 82b9b64 commit f2a515d

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

trino-aws-proxy-glue/src/main/java/io/trino/aws/proxy/glue/rest/TrinoGlueResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public TrinoGlueResource(ObjectMapper objectMapper, GlueRequestHandler requestHa
5959
@Produces(MediaType.APPLICATION_JSON)
6060
public Response gluePost(@Context Request request, @Context SigningMetadata signingMetadata, @Context RequestLoggingSession requestLoggingSession)
6161
{
62-
requestLoggingSession.logProperty("request.glue.emulated.key", signingMetadata.credentials().emulated().secretKey());
62+
requestLoggingSession.logProperty("request.glue.emulated.access-key", signingMetadata.credentials().emulated().accessKey());
6363

6464
String target = request.requestHeaders().unmodifiedHeaders().getFirst("x-amz-target")
6565
.orElseThrow(() -> InvalidInputException.builder().statusCode(BAD_REQUEST.getStatusCode()).build());

trino-aws-proxy/src/main/java/io/trino/aws/proxy/server/rest/TrinoS3Resource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private void handler(Request request, SigningMetadata signingMetadata, RequestLo
124124

125125
requestLoggingSession.logProperty("request.parsed.bucket", parsedS3Request.bucketName());
126126
requestLoggingSession.logProperty("request.parsed.key", parsedS3Request.keyInBucket());
127-
requestLoggingSession.logProperty("request.emulated.key", signingMetadata.credentials().emulated().secretKey());
127+
requestLoggingSession.logProperty("request.emulated.access-key", signingMetadata.credentials().emulated().accessKey());
128128

129129
proxyClient.proxyRequest(signingMetadata, parsedS3Request, asyncResponse, requestLoggingSession);
130130
}

0 commit comments

Comments
 (0)